From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763579AbdEWLU6 (ORCPT ); Tue, 23 May 2017 07:20:58 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:42115 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762408AbdEWLUz (ORCPT ); Tue, 23 May 2017 07:20:55 -0400 Subject: Re: [PATCH] mm: Define KB, MB, GB, TB in core VM To: Vlastimil Babka , Christoph Hellwig , Andrew Morton References: <20170522111742.29433-1-khandual@linux.vnet.ibm.com> <20170522141149.9ef84bb0713769f4af0383f0@linux-foundation.org> <20170523070227.GA27864@infradead.org> <09a6bafa-5743-425e-8def-bd9219cd756c@suse.cz> Cc: Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Anshuman Khandual Date: Tue, 23 May 2017 16:49:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <09a6bafa-5743-425e-8def-bd9219cd756c@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17052311-0048-0000-0000-00000231AAC6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17052311-0049-0000-0000-000047E0598C Message-Id: <161638da-3b2b-7912-2ae2-3b2936ca1537@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-23_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705230059 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/23/2017 02:08 PM, Vlastimil Babka wrote: > On 05/23/2017 09:02 AM, Christoph Hellwig wrote: >> On Mon, May 22, 2017 at 02:11:49PM -0700, Andrew Morton wrote: >>> On Mon, 22 May 2017 16:47:42 +0530 Anshuman Khandual wrote: >>> >>>> There are many places where we define size either left shifting integers >>>> or multiplying 1024s without any generic definition to fall back on. But >>>> there are couples of (powerpc and lz4) attempts to define these standard >>>> memory sizes. Lets move these definitions to core VM to make sure that >>>> all new usage come from these definitions eventually standardizing it >>>> across all places. >>> Grep further - there are many more definitions and some may now >>> generate warnings. >>> >>> Newly including mm.h for these things seems a bit heavyweight. I can't >>> immediately think of a more appropriate place. Maybe printk.h or >>> kernel.h. >> IFF we do these kernel.h is the right place. And please also add the >> MiB & co variants for the binary versions right next to the decimal >> ones. > Those defined in the patch are binary, not decimal. Do we even need > decimal ones? > I can define KiB, MiB, .... with the same values as binary. Did not get about the decimal ones, we need different names for them holding values which are multiple of 1024 ?