From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5BDC433E5 for ; Mon, 22 Mar 2021 13:24:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99DBB61920 for ; Mon, 22 Mar 2021 13:24:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbhCVNXv (ORCPT ); Mon, 22 Mar 2021 09:23:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:38844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231971AbhCVNUN (ORCPT ); Mon, 22 Mar 2021 09:20:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C6CF761930; Mon, 22 Mar 2021 13:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616419213; bh=DEM5m42T6fPO1L4ytDHAvL93o+qWMGXRGdg6w0KHqpM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d0/Tjs95plgTlxflkC/2arhZPTi+AX9eUSqC9/Iet8NbuDjHxh39zImbo+GThacHk g0tSDJCaV4Uf3Z0uC2N8Z5kdFnq2lg0StYVG3ePTW/VUR8oeR9Agsnte+RLgZjD1DE LrsqMBW2mpaA3zkMmAtcrq1SiZeFDrDHJo8orKBgOLOEJ4sy6kKRUSGU5ppAbFXnbT +Z6gc1kHDeSRJI8+kanQpE9xOeN9wqqBnGvY8TUVNM8OfWekznsvwcwm0kJClqxtoS PGqy13QjDqdKYH8McJCNX9CPs4dKXildtYiy+LADPvwLfflZtGQ9JK9mbDSGrP1/tf 1COaFmQG7Tkag== From: Will Deacon To: Pavel Tatashin , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jmorris@namei.org, catalin.marinas@arm.com, tyhicks@linux.microsoft.com Cc: kernel-team@android.com, Will Deacon Subject: Re: [PATCH] arm64: kdump: update ppos when reading elfcorehdr Date: Mon, 22 Mar 2021 13:19:57 +0000 Message-Id: <161641719902.3900979.10337880549161097433.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210319205054.743368-1-pasha.tatashin@soleen.com> References: <20210319205054.743368-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Mar 2021 16:50:54 -0400, Pavel Tatashin wrote: > The ppos points to a position in the old kernel memory (and in case of > arm64 in the crash kernel since elfcorehdr is passed as a segment). The > function should update the ppos by the amount that was read. This bug is > not exposed by accident, but other platforms update this value properly. > So, fix it in ARM64 version of elfcorehdr_read() as well. Applied to arm64 (for-next/fixes), thanks! [1/1] arm64: kdump: update ppos when reading elfcorehdr https://git.kernel.org/arm64/c/141f8202cfa4 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev