From: Dong Aisheng <aisheng.dong@nxp.com>
To: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, abel.vesa@nxp.com,
Dong Aisheng <aisheng.dong@nxp.com>
Subject: [PATCH V2 4/6] PM / devfreq: bail out early if no freq changes in devfreq_set_target
Date: Tue, 23 Mar 2021 10:59:17 +0800 [thread overview]
Message-ID: <1616468359-14513-5-git-send-email-aisheng.dong@nxp.com> (raw)
In-Reply-To: <1616468359-14513-1-git-send-email-aisheng.dong@nxp.com>
It's unnecessary to set the same freq again and run notifier calls.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
drivers/devfreq/devfreq.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index b537fd9602cd..cacda7d1f858 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -403,13 +403,16 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq,
{
struct devfreq_freqs freqs;
unsigned long cur_freq;
- int err = 0;
+ int err;
if (devfreq->profile->get_cur_freq)
devfreq->profile->get_cur_freq(devfreq->dev.parent, &cur_freq);
else
cur_freq = devfreq->previous_freq;
+ if (new_freq == cur_freq)
+ return 0;
+
freqs.old = cur_freq;
freqs.new = new_freq;
devfreq_notify_transition(devfreq, &freqs, DEVFREQ_PRECHANGE);
@@ -426,7 +429,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq,
* and DEVFREQ_POSTCHANGE because for showing the correct frequency
* change order of between devfreq device and passive devfreq device.
*/
- if (trace_devfreq_frequency_enabled() && new_freq != cur_freq)
+ if (trace_devfreq_frequency_enabled())
trace_devfreq_frequency(devfreq, new_freq, cur_freq);
devfreq_update_transitions(devfreq, cur_freq, new_freq,
@@ -445,7 +448,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq,
if (devfreq->suspend_freq)
devfreq->resume_freq = new_freq;
- return err;
+ return 0;
}
/**
--
2.25.1
next prev parent reply other threads:[~2021-03-23 3:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 2:59 [PATCH V2 0/6] PM / devfreq: a few small fixes and improvements Dong Aisheng
2021-03-23 2:59 ` [PATCH V2 1/6] PM / devfreq: fix build error when DEVFREQ_GOV_PASSIVE enabled Dong Aisheng
2021-03-23 2:59 ` [PATCH V2 2/6] PM / devfreq: Use more accurate returned new_freq as resume_freq Dong Aisheng
2021-03-23 2:59 ` [PATCH V2 3/6] PM / devfreq: Remove the invalid description for get_target_freq Dong Aisheng
2021-03-23 2:59 ` Dong Aisheng [this message]
2021-03-23 2:59 ` [PATCH V2 5/6] PM / devfreq: governor: optimize simpleondemand get_target_freq Dong Aisheng
2021-03-23 2:59 ` [PATCH V2 6/6] PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status Dong Aisheng
2021-03-23 3:25 ` [PATCH V2 0/6] PM / devfreq: a few small fixes and improvements Dong Aisheng
2021-03-23 4:11 ` Chanwoo Choi
2021-03-23 6:11 ` Aisheng Dong
2021-03-23 7:26 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616468359-14513-5-git-send-email-aisheng.dong@nxp.com \
--to=aisheng.dong@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=dongas86@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®