From: Jian Dong <dj0227@163.com>
To: matthias.bgg@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, huyue2@yulong.com,
Jian Dong <dongjian@yulong.com>
Subject: [PATCH] regulator: Use IRQF_ONESHOT
Date: Tue, 23 Mar 2021 20:12:18 +0800 [thread overview]
Message-ID: <1616501538-120724-1-git-send-email-dj0227@163.com> (raw)
From: Jian Dong <dongjian@yulong.com>
Fixes coccicheck error:
drivers/regulator/mt6360-regulator.c:388:8-33: ERROR:
drivers/regulator/pca9450-regulator.c:781:7-32: ERROR:
drivers/regulator/slg51000-regulator.c:480:8-33: ERROR:
drivers/regulator/qcom-labibb-regulator.c:364:8-33: ERROR:
Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Signed-off-by: Jian Dong <dongjian@yulong.com>
---
drivers/regulator/mt6360-regulator.c | 4 ++--
drivers/regulator/pca9450-regulator.c | 2 +-
drivers/regulator/qcom-labibb-regulator.c | 3 ++-
drivers/regulator/slg51000-regulator.c | 4 ++--
4 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/mt6360-regulator.c b/drivers/regulator/mt6360-regulator.c
index 15308ee..947350d 100644
--- a/drivers/regulator/mt6360-regulator.c
+++ b/drivers/regulator/mt6360-regulator.c
@@ -385,8 +385,8 @@ static int mt6360_regulator_irq_register(struct platform_device *pdev,
return irq;
}
- ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handler, 0,
- irq_desc->name, rdev);
+ ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handler,
+ IRQF_ONESHOT, irq_desc->name, rdev);
if (ret) {
dev_err(&pdev->dev, "Fail to request %s irq\n", irq_desc->name);
return ret;
diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index 2f7ee21..d4bc1c3 100644
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -780,7 +780,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c,
ret = devm_request_threaded_irq(pca9450->dev, pca9450->irq, NULL,
pca9450_irq_handler,
- (IRQF_TRIGGER_FALLING | IRQF_ONESHOT),
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"pca9450-irq", pca9450);
if (ret != 0) {
dev_err(pca9450->dev, "Failed to request IRQ: %d\n",
diff --git a/drivers/regulator/qcom-labibb-regulator.c b/drivers/regulator/qcom-labibb-regulator.c
index de25e32..cac5fd5 100644
--- a/drivers/regulator/qcom-labibb-regulator.c
+++ b/drivers/regulator/qcom-labibb-regulator.c
@@ -362,7 +362,8 @@ static int qcom_labibb_set_ocp(struct regulator_dev *rdev)
return ret;
return devm_request_threaded_irq(vreg->dev, vreg->ocp_irq, NULL,
- qcom_labibb_ocp_isr, irq_flags,
+ qcom_labibb_ocp_isr,
+ irq_flags | IRQF_ONESHOT,
ocp_irq_name, vreg);
}
diff --git a/drivers/regulator/slg51000-regulator.c b/drivers/regulator/slg51000-regulator.c
index 75a941f..3f310ab 100644
--- a/drivers/regulator/slg51000-regulator.c
+++ b/drivers/regulator/slg51000-regulator.c
@@ -479,8 +479,8 @@ static int slg51000_i2c_probe(struct i2c_client *client)
if (chip->chip_irq) {
ret = devm_request_threaded_irq(dev, chip->chip_irq, NULL,
slg51000_irq_handler,
- (IRQF_TRIGGER_HIGH |
- IRQF_ONESHOT),
+ IRQF_TRIGGER_HIGH |
+ IRQF_ONESHOT,
"slg51000-irq", chip);
if (ret != 0) {
dev_err(dev, "Failed to request IRQ: %d\n",
--
1.9.1
next reply other threads:[~2021-03-23 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 12:12 Jian Dong [this message]
2021-03-25 11:59 ` Krzysztof Kozlowski
2021-03-25 12:29 ` Felipe Balbi
2021-03-25 13:05 ` Jian Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616501538-120724-1-git-send-email-dj0227@163.com \
--to=dj0227@163.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dongjian@yulong.com \
--cc=huyue2@yulong.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®