From: "tip-bot2 for Rasmus Villemoes" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/core: Use -EINVAL in sched_dynamic_mode()
Date: Thu, 25 Mar 2021 11:08:37 -0000 [thread overview]
Message-ID: <161667051768.398.4185188604723886727.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210325004515.531631-2-linux@rasmusvillemoes.dk>
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c4681f3f1cfcfde0c95ff72f0bdb43f9ffd7f00e
Gitweb: https://git.kernel.org/tip/c4681f3f1cfcfde0c95ff72f0bdb43f9ffd7f00e
Author: Rasmus Villemoes <linux@rasmusvillemoes.dk>
AuthorDate: Thu, 25 Mar 2021 01:45:15 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 25 Mar 2021 11:39:13 +01:00
sched/core: Use -EINVAL in sched_dynamic_mode()
-1 is -EPERM which is a somewhat odd error to return from
sched_dynamic_write(). No other callers care about which negative
value is used.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: https://lore.kernel.org/r/20210325004515.531631-2-linux@rasmusvillemoes.dk
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 1fe9d3f..95bd6ab 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5384,7 +5384,7 @@ static int sched_dynamic_mode(const char *str)
if (!strcmp(str, "full"))
return preempt_dynamic_full;
- return -1;
+ return -EINVAL;
}
static void sched_dynamic_update(int mode)
next prev parent reply other threads:[~2021-03-25 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 0:45 [PATCH 1/2] sched: stop using magic values in sched_dynamic_mode Rasmus Villemoes
2021-03-25 0:45 ` [PATCH 2/2] sched: use -EINVAL " Rasmus Villemoes
2021-03-25 11:08 ` tip-bot2 for Rasmus Villemoes [this message]
2021-03-25 7:48 ` [PATCH 1/2] sched: stop using magic values " Peter Zijlstra
2021-03-25 11:08 ` [tip: sched/core] sched/core: Stop using magic values in sched_dynamic_mode() tip-bot2 for Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161667051768.398.4185188604723886727.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®