From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755484AbbE2J3V (ORCPT ); Fri, 29 May 2015 05:29:21 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:60020 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763AbbE2J3M convert rfc822-to-8bit (ORCPT ); Fri, 29 May 2015 05:29:12 -0400 Date: Fri, 29 May 2015 11:29:09 +0200 (CEST) From: robert.jarzmik@free.fr To: Vinod Koul Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <1617548760.717381111.1432891749082.JavaMail.root@zimbra1-e1.priv.proxad.net> In-Reply-To: <20150529091345.GE3140@localhost> Subject: Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [192.198.151.43] X-Mailer: Zimbra 7.2.0-GA2598 (ZimbraWebClient - FF3.0 (Linux)/7.2.0-GA2598) X-Authenticated-User: robert.jarzmik@free.fr Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Mail original ----- De: "Vinod Koul" À: "Robert Jarzmik" On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote: > This fixes the following error: > drivers/dma/pxa_dma.c: In function ‘dbg_show_requester_chan’: > drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be > pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx); > Applied now. Thanks. > but not pleased that you sent broken code. Sending stuff that > compiles is basic step You should know me better by now. I told you I compiled *and* tested. And with a a bit closer look check this commit, especially the date : commit 0bac33653b06a5f80a5c04e275eb33db9493b85a Author: Joe Perches Date: Sat May 23 12:00:38 2015 +1000 fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void Cheers. -- Robert