From: Luo Jiaxing <luojiaxing@huawei.com>
To: <kashyap.desai@broadcom.com>, <sumit.saxena@broadcom.com>,
<shivasharan.srikanteshwara@broadcom.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>
Cc: <megaraidlinux.pdl@broadcom.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<luojiaxing@huawei.com>
Subject: [PATCH v1 5/8] scsi: megaraid: clean up for "foo * bar"
Date: Sat, 10 Apr 2021 14:48:04 +0800 [thread overview]
Message-ID: <1618037287-460-6-git-send-email-luojiaxing@huawei.com> (raw)
In-Reply-To: <1618037287-460-1-git-send-email-luojiaxing@huawei.com>
Following error is reported by checkpatch.pl:
"foo * bar" should be "foo *bar"
+ struct megasas_iocpacket __user * user_ioc,
The format of the pointer variable must be "foo *bar", so fix
them.
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
---
drivers/scsi/megaraid/megaraid_ioctl.h | 4 ++--
drivers/scsi/megaraid/megaraid_mbox.h | 2 +-
drivers/scsi/megaraid/megaraid_mm.c | 4 ++--
drivers/scsi/megaraid/megaraid_sas_base.c | 4 ++--
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_ioctl.h b/drivers/scsi/megaraid/megaraid_ioctl.h
index 87b880fe..9bc0250 100644
--- a/drivers/scsi/megaraid/megaraid_ioctl.h
+++ b/drivers/scsi/megaraid/megaraid_ioctl.h
@@ -126,7 +126,7 @@ typedef struct uioc {
uint8_t reserved[128];
/* Driver Data: */
- void __user * user_data;
+ void __user *user_data;
uint32_t user_data_len;
/* 64bit alignment */
@@ -138,7 +138,7 @@ typedef struct uioc {
dma_addr_t pthru32_h;
struct list_head list;
- void (*done)(struct uioc*);
+ void (*done)(struct uioc *);
caddr_t buf_vaddr;
dma_addr_t buf_paddr;
diff --git a/drivers/scsi/megaraid/megaraid_mbox.h b/drivers/scsi/megaraid/megaraid_mbox.h
index d2fe7f6..3c16d38 100644
--- a/drivers/scsi/megaraid/megaraid_mbox.h
+++ b/drivers/scsi/megaraid/megaraid_mbox.h
@@ -189,7 +189,7 @@ typedef struct {
dma_addr_t mbox_dma;
spinlock_t mailbox_lock;
unsigned long baseport;
- void __iomem * baseaddr;
+ void __iomem *baseaddr;
struct mraid_pci_blk mbox_pool[MBOX_MAX_SCSI_CMDS];
struct dma_pool *mbox_pool_handle;
struct mraid_pci_blk epthru_pool[MBOX_MAX_SCSI_CMDS];
diff --git a/drivers/scsi/megaraid/megaraid_mm.c b/drivers/scsi/megaraid/megaraid_mm.c
index 864cbb6..234885c 100644
--- a/drivers/scsi/megaraid/megaraid_mm.c
+++ b/drivers/scsi/megaraid/megaraid_mm.c
@@ -582,7 +582,7 @@ static uioc_t *
mraid_mm_alloc_kioc(mraid_mmadp_t *adp)
{
uioc_t *kioc;
- struct list_head* head;
+ struct list_head *head;
unsigned long flags;
down(&adp->kioc_semaphore);
@@ -722,7 +722,7 @@ ioctl_done(uioc_t *kioc)
{
uint32_t adapno;
int iterator;
- mraid_mmadp_t* adapter;
+ mraid_mmadp_t *adapter;
/*
* When the kioc returns from driver, make sure it still doesn't
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 40c77bb..2b17529 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4402,7 +4402,7 @@ int megasas_alloc_cmds(struct megasas_instance *instance)
* Allocate the dynamic array first and then allocate individual
* commands.
*/
- instance->cmd_list = kcalloc(max_cmd, sizeof(struct megasas_cmd*), GFP_KERNEL);
+ instance->cmd_list = kcalloc(max_cmd, sizeof(struct megasas_cmd *), GFP_KERNEL);
if (!instance->cmd_list) {
dev_printk(KERN_DEBUG, &instance->pdev->dev, "out of memory\n");
@@ -8150,7 +8150,7 @@ static int megasas_set_crash_dump_params_ioctl(struct megasas_cmd *cmd)
*/
static int
megasas_mgmt_fw_ioctl(struct megasas_instance *instance,
- struct megasas_iocpacket __user * user_ioc,
+ struct megasas_iocpacket __user *user_ioc,
struct megasas_iocpacket *ioc)
{
struct megasas_sge64 *kern_sge64 = NULL;
--
2.7.4
next prev parent reply other threads:[~2021-04-10 6:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 6:47 [PATCH v1 0/8] scsi: megaraid: some misc clean up patches Luo Jiaxing
2021-04-10 6:48 ` [PATCH v1 1/8] scsi: megaraid: clean up for white space Luo Jiaxing
2021-04-10 6:48 ` [PATCH v1 2/8] scsi: megaraid_sas: use parentheses to enclose macros with complex values Luo Jiaxing
2021-04-10 6:48 ` [PATCH v1 3/8] scsi: megaraid: clean up for blank lines Luo Jiaxing
2021-04-10 6:48 ` [PATCH v1 4/8] scsi: megaraid: clean up for open/close brace Luo Jiaxing
2021-04-10 6:48 ` Luo Jiaxing [this message]
2021-04-10 6:48 ` [PATCH v1 6/8] scsi: megaraid: clean up for code indent Luo Jiaxing
2021-04-10 6:48 ` [PATCH v1 7/8] scsi: megaraid: clean up for trailing statements Luo Jiaxing
2021-04-10 6:48 ` [PATCH v1 8/8] scsi: megaraid: clean up for static variable initialise to 0 Luo Jiaxing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1618037287-460-6-git-send-email-luojiaxing@huawei.com \
--to=luojiaxing@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®