From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
To: Mel Gorman <mgorman@techsingularity.net>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Subject: [PATCH] sched/fair: Fix unsetting of "has_idle_cores" flag
Date: Mon, 26 Apr 2021 22:34:12 +0530 [thread overview]
Message-ID: <1619456652-19143-1-git-send-email-ego@linux.vnet.ibm.com> (raw)
From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
In commit 9fe1f127b913 ("sched/fair: Merge select_idle_core/cpu()"), in
select_idle_cpu(), we check if an idle core is present in the LLC of the
target CPU via the flag "has_idle_cores". We look for the idle core in
select_idle_cores(). If select_idle_cores() isn't able to find an idle
core/CPU, we need to unset the has_idle_cores flag in the LLC of the
target to prevent other CPUs from going down this route.
However, the current code is unsetting it in the LLC of the current CPU
instead of the target CPU. This patch fixes this issue.
Fixes: Commit 9fe1f127b913 ("sched/fair: Merge select_idle_core/cpu()")
Cc: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 794c2cb..5fb5020 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6171,7 +6171,7 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, int t
}
if (smt)
- set_idle_cores(this, false);
+ set_idle_cores(target, false);
if (sched_feat(SIS_PROP) && !smt) {
time = cpu_clock(this) - time;
--
1.9.4
next reply other threads:[~2021-04-26 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 17:04 Gautham R. Shenoy [this message]
2021-04-27 7:08 ` Vincent Guittot
2021-04-27 7:55 ` Mel Gorman
2021-05-10 16:00 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619456652-19143-1-git-send-email-ego@linux.vnet.ibm.com \
--to=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®