From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbeEUCAk (ORCPT ); Sun, 20 May 2018 22:00:40 -0400 Received: from gateway22.websitewelcome.com ([192.185.47.109]:33889 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbeEUCAh (ORCPT ); Sun, 20 May 2018 22:00:37 -0400 X-Authority-Reason: nr=8 Subject: Re: [PATCH] kernel: sys: fix potential Spectre v1 From: "Gustavo A. R. Silva" To: Dan Williams Cc: Thomas Gleixner , Andrew Morton , Linux Kernel Mailing List , Alexei Starovoitov , Peter Zijlstra References: <20180515030038.GA11822@embeddedor.com> <20180515150859.1bccbd8d4543848b30fea859@linux-foundation.org> <50481b83-4c03-f354-bd11-cef7aecdd85f@embeddedor.com> <3d2e5771-c2c9-6e45-3e85-21c0bc86876e@embeddedor.com> <58df7ae3-8ef0-4f42-9ab2-b551d2ffff00@embeddedor.com> Message-ID: <161a0513-1029-a76c-f967-1e606081599d@embeddedor.com> Date: Sun, 20 May 2018 21:00:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <58df7ae3-8ef0-4f42-9ab2-b551d2ffff00@embeddedor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.192.46.223 X-Source-L: No X-Exim-ID: 1fKa7m-00337T-HA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.70]) [187.192.46.223]:39216 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/20/2018 07:50 PM, Gustavo A. R. Silva wrote: > > > On 05/18/2018 03:44 PM, Gustavo A. R. Silva wrote: >>>> >>>> #ifndef sanitize_index_nospec >>>> inline bool sanitize_index_nospec(unsigned long *index, >>>>                                    unsigned long size) >>>> { >>>>          if (*index >= size) >>>>                  return false; >>>>          *index = array_index_nospec(*index, size); >>>> >>>>          return true; >>>> } >>>> #endif >>> >>> I think this is fine in concept, we already do something similar in >>> mpls_label_ok(). Perhaps call it validate_index_nospec() since >>> validation is something that can fail, but sanitization in theory is >>> something that can always succeed. >>> >> >> OK. I got it. >> >>> However, the problem is the data type of the index. I expect you would >>> need to do this in a macro and use typeof() if you wanted this to be >>> generally useful, and also watch out for multiple usage of a macro >>> argument. Is it still worth it at that point? >>> >> >> Yeah. I think it is worth it. I'll work on this during the weekend and >> send a proper patch for review. >> > > Dan, > > What do you think about this first draft: > > diff --git a/include/linux/nospec.h b/include/linux/nospec.h > index e791ebc..6154183 100644 > --- a/include/linux/nospec.h > +++ b/include/linux/nospec.h > @@ -55,4 +55,16 @@ static inline unsigned long > array_index_mask_nospec(unsigned long index, >                                                                        \ >         (typeof(_i)) (_i & _mask);                                     \ >  }) > + > +#define validate_index_nospec(index, size)                            \ > +({                                                                    \ > +       typeof(index) *ptr = &(index);                                 \ > +       typeof(size) _s = (size);                                      \ > +                                                                      \ > +       BUILD_BUG_ON(sizeof(*ptr) > sizeof(long));                     \ > +       BUILD_BUG_ON(sizeof(_s) > sizeof(long));                       \ > +                                                                      \ > +       *ptr >= _s ? false :                                           \ > +       (*ptr = array_index_nospec(*ptr, _s) ? true : true);           \ This actually should be: ((*ptr = array_index_nospec(*ptr, _s)) ? true : true); > +}) >  #endif /* _LINUX_NOSPEC_H */ > > Thanks > -- > Gustavo