From: Andrey Ryabinin <arbn@yandex-team.com>
To: Daniel Jordan <daniel.m.jordan@oracle.com>,
Dan Schatzberg <schatzberg.dan@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>, Boris Burkov <boris@bur.io>,
"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] cgroup: Fix rootcg cpu.stat guest double counting
Date: Mon, 15 Nov 2021 19:41:12 +0300 [thread overview]
Message-ID: <161a70b7-ee6f-bbc7-8a2e-1fd42fcba3eb@yandex-team.com> (raw)
In-Reply-To: <20211029172129.smeyk5adocjrwtlb@oracle.com>
On 10/29/21 8:21 PM, Daniel Jordan wrote:
> On Thu, Oct 28, 2021 at 03:15:27PM -0700, Dan Schatzberg wrote:
>> In account_guest_time in kernel/sched/cputime.c guest time is
>> attributed to both CPUTIME_NICE and CPUTIME_USER in addition to
>> CPUTIME_GUEST_NICE and CPUTIME_GUEST respectively. Therefore, adding
>> both to calculate usage results in double counting any guest time at
>> the rootcg.
>
> Yes, definitely a bug. The same fix was posted a couple months ago as
> part of a series but never picked up:
>
> https://x-lore.kernel.org/all/20210820094005.20596-3-arbn@yandex-team.com/
>
> The series also touched cputime, so we might be waiting for scheduler
> folks? +Ingo +Peter +Andrey
>
Yeah, I'll do rebase and send v3
next prev parent reply other threads:[~2021-11-15 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 22:15 Dan Schatzberg
2021-10-29 17:21 ` Daniel Jordan
2021-11-15 16:41 ` Andrey Ryabinin [this message]
2021-11-01 16:48 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161a70b7-ee6f-bbc7-8a2e-1fd42fcba3eb@yandex-team.com \
--to=arbn@yandex-team.com \
--cc=boris@bur.io \
--cc=cgroups@vger.kernel.org \
--cc=daniel.m.jordan@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=schatzberg.dan@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®