Re: [PATCH 3/4] ARM: dts: qcom: msm8960: expressatt: Add Magnetometer

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 11/20/25 8:14 AM, Rudraksha Gupta via B4 Relay wrote:
> From: Rudraksha Gupta <guptarud@gmail.com>
> 
> Add the Yamaha magnetometer. Mount Matrix is left as a TODO.
> 
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
>  .../boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts  | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts
> index 81806d7ca001..403bef67a148 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts
> @@ -490,3 +490,21 @@ &usb1 {
>  	dr_mode = "otg";
>  	status = "okay";
>  };
> +
> +&gsbi12 {
> +	qcom,mode = <GSBI_PROT_I2C>;
> +	status = "okay";

Please add a \n before status

> +};
> +
> +&gsbi12_i2c {
> +	status = "okay";
> +
> +	magnetometer@2e {
> +		compatible = "yamaha,yas532";
> +		reg = <0x2e>;
> +		vdd-supply   = <&pm8921_l9>;

Odd double space

> +		iovdd-supply = <&pm8921_lvs4>;
> +
> +		// TODO: Figure out Mount Matrix

pmOS wiki has this:

https://github.com/SiddharthManthan/accelerometer-mount-matrix-generator/blob/master/rotation_matrix.py

but for accelerometers.. shouldn't be too different, I would assume

Konrad