From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752839AbdHKJfI (ORCPT ); Fri, 11 Aug 2017 05:35:08 -0400 Received: from mout.web.de ([212.227.15.4]:65396 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbdHKJfE (ORCPT ); Fri, 11 Aug 2017 05:35:04 -0400 To: alsa-devel@alsa-project.org, Jaroslav Kysela , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Takashi Iwai , Vinod Koul Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ASoC: Medfield: Delete an error message for a failed memory allocation in snd_mfld_mc_probe() Message-ID: <161e9c4c-1c97-d06f-35ec-3f165ad9e52e@users.sourceforge.net> Date: Fri, 11 Aug 2017 11:33:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Ag9ovIkkVz3F0Lst+472r/38qMqVwdUVZk2KvlzmwtjzbKdNfih zZhXkInk63ahQF9IFsqs6iqZP/l8R9pKUR+2pCTrr3clKoguBpMZ+rc+/gc01v/AWUL6X2N pDjc3k/eYZ60XAG1S0kDdAfAA68kIRipp949FRJ/c0Cc7Cab+8aM+4Y5R/WFZuia9B62bXY hk312p+Eh2PHLckRabHQg== X-UI-Out-Filterresults: notjunk:1;V01:K0:XG1XTxI+gcI=:IE9vGZ1iNm5wXopAgRhtrd 0Dtb4OVF2AGV/pYRbGRkcBpJET78kZx+Hy9BgedJ/V/rr7A/3nodhB86dDcNps3FE6JVrB3gR TWhVsgXeSeZSnowtoq/M5B56RxLwCM1KSm1Bezi0R1ZeMtqGLDlPikb9b5v5tJsXMMKRQEPYi UlL0LK0KyqAEOvkreUgNepJgmDNuKPECThsaR+Ykd+JuPMV8yLAhSvOwLRYdtfXk34nGPvdYB I5r9UypgpMyuHJwb/i9pZa5Kmohej2E+hJNLzUmoP04xm3867ROcHy3cEL0mPMnAE2s7rqfF/ jpLZBbxKI81eyg06IC6hoWWQhwI+B2dRtwmnFivIur7cxCqIpSPJpKHNK6RD4MAnZDWVEjyTH kaMDrqzSilwNo6tlDQoFNq3p8fTKWHda97fqqGhD7wIKSNDf95KCawqb7YTBS7lN4e8xKRADx keMgAUmSTgEf9XYXznETO+qfVXF6hN1wx93cS9ViBkSJNpRcCg4RNmcEaUvQ4vfhhxgz40ikR D1GsayxOtE1ozaxwz57siRKcxsgU29HWWq2MH1FVy2iI/Deg3hoXUhwHkUKBpa5nlcoTZGgtl SU7CPZJxZyYvEmwn4jrpLC1ZSn0Bx/y+zsN/8cpCDUo9x4lhP1M4IyiWsZBkD8Ki7YHgFiAp5 Jn8juKL0saF3cG9lKwXz6ivNYRKjBsxzXaOjSoeRSY/AwA0tX3hl6aMdwg+ZcPRhkZUwnMnZ0 eUC8rhdavsrZoxGSCOymgcNY2lwwrtiiOtmKZqCnuds8FaGyvsaEgXpq22DnWSNjNbOqNU47d moD9xxlL2QD6w4ULMudkqpdNQwpX0+vc5OIR9NDn5L3jPGS9ws= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 11 Aug 2017 11:25:41 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- sound/soc/intel/boards/mfld_machine.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/intel/boards/mfld_machine.c b/sound/soc/intel/boards/mfld_machine.c index 4e08885f37aa..6f44acfb4aae 100644 --- a/sound/soc/intel/boards/mfld_machine.c +++ b/sound/soc/intel/boards/mfld_machine.c @@ -376,10 +376,8 @@ static int snd_mfld_mc_probe(struct platform_device *pdev) /* audio interrupt base of SRAM location where * interrupts are stored by System FW */ mc_drv_ctx = devm_kzalloc(&pdev->dev, sizeof(*mc_drv_ctx), GFP_ATOMIC); - if (!mc_drv_ctx) { - pr_err("allocation failed\n"); + if (!mc_drv_ctx) return -ENOMEM; - } irq_mem = platform_get_resource_byname( pdev, IORESOURCE_MEM, "IRQ_BASE"); -- 2.14.0