From: "John Stoffel" <stoffel@lucent.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [TRIVIAL] Patch to for Cyclades ISA serial board under 2.6
Date: Wed, 27 Aug 2003 13:33:20 -0400 [thread overview]
Message-ID: <16204.60256.756215.90139@gargle.gargle.HOWL> (raw)
Quick patch to get my 8 port Cyclades Cyclom-Y ISA card to work under
2.6.0-test3 and higher:
--- linux-2.6.0-test3/drivers/char/cyclades.c Sat Aug 9 00:33:22 2003
+++ linux-2.6.0-test1-mm2/drivers/char/cyclades.c Tue Jul 22 23:19:19 2003
@@ -867,6 +867,7 @@
static int cyz_issue_cmd(struct cyclades_card *, uclong, ucchar, uclong);
#ifdef CONFIG_ISA
static unsigned detect_isa_irq (volatile ucchar *);
+spinlock_t isa_card_lock = SPIN_LOCK_UNLOCKED;
#endif /* CONFIG_ISA */
static int cyclades_get_proc_info(char *, char **, off_t , int , int *, void *;
@@ -1050,14 +1051,14 @@
udelay(5000L);
/* Enable the Tx interrupts on the CD1400 */
- save_flags(flags); cli();
+ spin_lock_irqsave(&isa_card_lock,flags);
cy_writeb((u_long)address + (CyCAR<<index), 0);
cyy_issue_cmd(address, CyCHAN_CTL|CyENB_XMTR, index);
cy_writeb((u_long)address + (CyCAR<<index), 0);
cy_writeb((u_long)address + (CySRER<<index),
cy_readb(address + (CySRER<<index)) | CyTxRdy);
- restore_flags(flags);
+ spin_unlock_irqrestore(&isa_card_lock, flags);
/* Wait ... */
udelay(5000L);
@@ -5665,7 +5666,7 @@
cy_cleanup_module(void)
{
int i;
- int e1;
+ int e1, e2;
unsigned long flags;
#ifndef CONFIG_CYZ_INTR
@@ -5675,13 +5676,10 @@
}
#endif /* CONFIG_CYZ_INTR */
- save_flags(flags); cli();
-
if ((e1 = tty_unregister_driver(cy_serial_driver)))
printk("cyc: failed to unregister Cyclades serial driver(%d)\n",
e1);
- restore_flags(flags);
put_tty_driver(cy_serial_driver);
for (i = 0; i < NR_CARDS; i++) {
next reply other threads:[~2003-08-27 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-27 17:33 John Stoffel [this message]
2003-09-20 5:26 Shine Mohamed
2003-09-25 15:02 Shine Mohamed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16204.60256.756215.90139@gargle.gargle.HOWL \
--to=stoffel@lucent.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®