From: Xiaofei Tan <tanxiaofei@huawei.com>
To: <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linuxarm@openeuler.org>,
Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH 03/17] tty: tty_buffer: Add a blank line after declarations
Date: Wed, 12 May 2021 17:26:11 +0800 [thread overview]
Message-ID: <1620811585-18582-4-git-send-email-tanxiaofei@huawei.com> (raw)
In-Reply-To: <1620811585-18582-1-git-send-email-tanxiaofei@huawei.com>
Add a blank line after declarations, reported by checkpatch.pl.
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
drivers/tty/tty_buffer.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index 9733469..5509b5d 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -91,6 +91,7 @@ EXPORT_SYMBOL_GPL(tty_buffer_unlock_exclusive);
int tty_buffer_space_avail(struct tty_port *port)
{
int space = port->buf.mem_limit - atomic_read(&port->buf.mem_used);
+
return max(space, 0);
}
EXPORT_SYMBOL_GPL(tty_buffer_space_avail);
@@ -312,11 +313,13 @@ int tty_insert_flip_string_fixed_flag(struct tty_port *port,
const unsigned char *chars, char flag, size_t size)
{
int copied = 0;
+
do {
int goal = min_t(size_t, size - copied, TTY_BUFFER_PAGE);
int flags = (flag == TTY_NORMAL) ? TTYB_NORMAL : 0;
int space = __tty_buffer_request_room(port, goal, flags);
struct tty_buffer *tb = port->buf.tail;
+
if (unlikely(space == 0))
break;
memcpy(char_buf_ptr(tb, tb->used), chars, space);
@@ -348,10 +351,12 @@ int tty_insert_flip_string_flags(struct tty_port *port,
const unsigned char *chars, const char *flags, size_t size)
{
int copied = 0;
+
do {
int goal = min_t(size_t, size - copied, TTY_BUFFER_PAGE);
int space = tty_buffer_request_room(port, goal);
struct tty_buffer *tb = port->buf.tail;
+
if (unlikely(space == 0))
break;
memcpy(char_buf_ptr(tb, tb->used), chars, space);
@@ -431,8 +436,10 @@ int tty_prepare_flip_string(struct tty_port *port, unsigned char **chars,
size_t size)
{
int space = __tty_buffer_request_room(port, size, TTYB_NORMAL);
+
if (likely(space)) {
struct tty_buffer *tb = port->buf.tail;
+
*chars = char_buf_ptr(tb, tb->used);
if (~tb->flags & TTYB_NORMAL)
memset(flag_buf_ptr(tb, tb->used), TTY_NORMAL, space);
--
2.8.1
next prev parent reply other threads:[~2021-05-12 9:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 9:26 [PATCH 00/17] tty: Fix some coding style issues Xiaofei Tan
2021-05-12 9:26 ` [PATCH 01/17] tty: tty_baudrate: Remove unnecessary tab and spaces in comment sentence Xiaofei Tan
2021-05-12 9:26 ` [PATCH 02/17] tty: tty_baudrate: Fix coding style issues of block comments Xiaofei Tan
2021-05-12 9:26 ` Xiaofei Tan [this message]
2021-05-12 9:26 ` [PATCH 04/17] tty: tty_buffer: Remove the repeated word 'the' Xiaofei Tan
2021-05-12 9:26 ` [PATCH 05/17] tty: tty_buffer: Fix coding style issues of block comments Xiaofei Tan
2021-05-12 9:26 ` [PATCH 06/17] tty: tty_io: Remove spaces before tabs Xiaofei Tan
2021-05-12 9:26 ` [PATCH 07/17] tty: tty_io: Add a blank line after declarations Xiaofei Tan
2021-05-12 9:26 ` [PATCH 08/17] tty: tty_io: Fix spaces required around that ':' Xiaofei Tan
2021-05-12 9:26 ` [PATCH 09/17] tty: tty_io: Fix trailing whitespace issues Xiaofei Tan
2021-05-12 9:26 ` [PATCH 10/17] tty: tty_io: Fix coding style issues of block comments Xiaofei Tan
2021-05-12 9:26 ` [PATCH 11/17] tty: tty_io: Remove the repeated word 'can' Xiaofei Tan
2021-05-12 9:26 ` [PATCH 12/17] tty: tty_io: Fix an issue of code indent for conditional statements Xiaofei Tan
2021-05-12 9:26 ` [PATCH 13/17] tty: tty_io: Delete a blank line before EXPORT_SYMBOL(foo) Xiaofei Tan
2021-05-12 9:26 ` [PATCH 14/17] tty: tty_io: Remove return in void function Xiaofei Tan
2021-05-12 9:26 ` [PATCH 15/17] tty: tty_port: Delete a blank line before EXPORT_SYMBOL(foo) Xiaofei Tan
2021-05-12 9:26 ` [PATCH 16/17] tty: tty_port: Add a blank line after declarations Xiaofei Tan
2021-05-12 9:26 ` [PATCH 17/17] tty: tty_port: Fix coding style issues of block comments Xiaofei Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1620811585-18582-4-git-send-email-tanxiaofei@huawei.com \
--to=tanxiaofei@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®