From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86ED2C433B4 for ; Thu, 13 May 2021 13:37:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B6F061221 for ; Thu, 13 May 2021 13:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234092AbhEMNii (ORCPT ); Thu, 13 May 2021 09:38:38 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2589 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233987AbhEMNie (ORCPT ); Thu, 13 May 2021 09:38:34 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Fgt1Z717pzsRGm; Thu, 13 May 2021 21:34:42 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Thu, 13 May 2021 21:37:13 +0800 From: Qi Liu To: CC: , Subject: [PATCH] intel_th: sth: Remove unnecessary return value Date: Thu, 13 May 2021 21:37:04 +0800 Message-ID: <1620913024-57219-1-git-send-email-liuqi115@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Junhao He intel_th_sw_init() always return true, it's unnecessary to keep the return value. Signed-off-by: Junhao He Signed-off-by: Qi Liu --- drivers/hwtracing/intel_th/sth.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/hwtracing/intel_th/sth.c b/drivers/hwtracing/intel_th/sth.c index 9ca8c4e..5d4effd 100644 --- a/drivers/hwtracing/intel_th/sth.c +++ b/drivers/hwtracing/intel_th/sth.c @@ -164,7 +164,7 @@ static int sth_stm_link(struct stm_data *stm_data, unsigned int master, return intel_th_set_output(to_intel_th_device(sth->dev), master); } -static int intel_th_sw_init(struct sth_device *sth) +static void intel_th_sw_init(struct sth_device *sth) { u32 reg; @@ -179,8 +179,6 @@ static int intel_th_sw_init(struct sth_device *sth) dev_dbg(sth->dev, "sw_start: %x sw_end: %x masters: %x nchannels: %x\n", sth->stm.sw_start, sth->stm.sw_end, sth->sw_nmasters, sth->stm.sw_nchannels); - - return 0; } static int intel_th_sth_probe(struct intel_th_device *thdev) @@ -221,9 +219,7 @@ static int intel_th_sth_probe(struct intel_th_device *thdev) sth->stm.sw_mmiosz = sizeof(struct intel_th_channel); sth->stm.link = sth_stm_link; - err = intel_th_sw_init(sth); - if (err) - return err; + intel_th_sw_init(sth); err = stm_register_device(dev, &sth->stm, THIS_MODULE); if (err) { -- 2.8.1