mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kai Ye <yekai13@huawei.com>
To: <marcel@holtmann.org>, <johan.hedberg@gmail.com>,
	<luiz.dentz@gmail.com>, <davem@davemloft.net>, <kuba@kernel.org>,
	<netdev@vger.kernel.org>, <linux-bluetooth@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <yekai13@huawei.com>
Subject: [PATCH v2 11/12] net/Bluetooth/sco - use the correct print format
Date: Fri, 21 May 2021 13:59:47 +0800	[thread overview]
Message-ID: <1621576788-48092-12-git-send-email-yekai13@huawei.com> (raw)
In-Reply-To: <1621576788-48092-1-git-send-email-yekai13@huawei.com>

According to Documentation/core-api/printk-formats.rst,
Use the correct print format. Printing an unsigned int value should use %u
instead of %d. Otherwise printk() might end up displaying negative numbers.

Signed-off-by: Kai Ye <yekai13@huawei.com>
---
 net/bluetooth/sco.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index 3bd4156..d9a4e88 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -310,7 +310,7 @@ static void sco_recv_frame(struct sco_conn *conn, struct sk_buff *skb)
 	if (!sk)
 		goto drop;
 
-	BT_DBG("sk %p len %d", sk, skb->len);
+	BT_DBG("sk %p len %u", sk, skb->len);
 
 	if (sk->sk_state != BT_CONNECTED)
 		goto drop;
@@ -905,7 +905,7 @@ static int sco_sock_getsockopt_old(struct socket *sock, int optname,
 
 		opts.mtu = sco_pi(sk)->conn->mtu;
 
-		BT_DBG("mtu %d", opts.mtu);
+		BT_DBG("mtu %u", opts.mtu);
 
 		len = min_t(unsigned int, len, sizeof(opts));
 		if (copy_to_user(optval, (char *)&opts, len))
@@ -1167,7 +1167,7 @@ static void sco_connect_cfm(struct hci_conn *hcon, __u8 status)
 	if (hcon->type != SCO_LINK && hcon->type != ESCO_LINK)
 		return;
 
-	BT_DBG("hcon %p bdaddr %pMR status %d", hcon, &hcon->dst, status);
+	BT_DBG("hcon %p bdaddr %pMR status %u", hcon, &hcon->dst, status);
 
 	if (!status) {
 		struct sco_conn *conn;
@@ -1196,7 +1196,7 @@ void sco_recv_scodata(struct hci_conn *hcon, struct sk_buff *skb)
 	if (!conn)
 		goto drop;
 
-	BT_DBG("conn %p len %d", conn, skb->len);
+	BT_DBG("conn %p len %u", conn, skb->len);
 
 	if (skb->len) {
 		sco_recv_frame(conn, skb);
-- 
2.8.1


  parent reply	other threads:[~2021-05-21  6:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21  5:59 [PATCH v2 00/12] net/Bluetooth: correct the use of " Kai Ye
2021-05-21  5:59 ` [PATCH v2 01/12] net/Bluetooth/bnep - use the correct " Kai Ye
2021-05-21  5:59 ` [PATCH v2 02/12] net/Bluetooth/cmtp " Kai Ye
2021-05-21  5:59 ` [PATCH v2 03/12] net/Bluetooth/hidp " Kai Ye
2021-05-21  5:59 ` [PATCH v2 04/12] net/Bluetooth/rfcomm " Kai Ye
2021-05-21  5:59 ` [PATCH v2 05/12] net/Bluetooth/6lowpan " Kai Ye
2021-05-21  5:59 ` [PATCH v2 06/12] net/Bluetooth/a2mp " Kai Ye
2021-05-21  5:59 ` [PATCH v2 07/12] net/Bluetooth/amp " Kai Ye
2021-05-21  5:59 ` [PATCH v2 08/12] net/Bluetooth/hci " Kai Ye
2021-05-21  5:59 ` [PATCH v2 09/12] net/Bluetooth/mgmt " Kai Ye
2021-05-21  5:59 ` [PATCH v2 10/12] net/Bluetooth/msft " Kai Ye
2021-05-21  5:59 ` Kai Ye [this message]
2021-05-21  5:59 ` [PATCH v2 12/12] net/Bluetooth/smp " Kai Ye
2021-06-02 20:18 ` [PATCH v2 00/12] net/Bluetooth: correct the use of " Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1621576788-48092-12-git-send-email-yekai13@huawei.com \
    --to=yekai13@huawei.com \
    --cc=davem@davemloft.net \
    --cc=johan.hedberg@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®