mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
	<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lipeng321@huawei.com>, <huangguangbin2@huawei.com>
Subject: [PATCH V2 net-next 04/11] net: z85230: remove redundant initialization for statics
Date: Mon, 14 Jun 2021 19:28:44 +0800	[thread overview]
Message-ID: <1623670131-49973-5-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1623670131-49973-1-git-send-email-huangguangbin2@huawei.com>

From: Peng Li <lipeng321@huawei.com>

Should not initialise statics to 0.
According to Documentation/process/volatile-considered-harmful.rst,
the "volatile" type class should not be used, so remove it.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>

---
Change Log:
V1 -> V2:
1, fix the comments from Andrew, add commit message
   about remove volatile.
---


---
 drivers/net/wan/z85230.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/z85230.c b/drivers/net/wan/z85230.c
index 94ed9a2..f815bb5 100644
--- a/drivers/net/wan/z85230.c
+++ b/drivers/net/wan/z85230.c
@@ -685,7 +685,7 @@ irqreturn_t z8530_interrupt(int irq, void *dev_id)
 {
 	struct z8530_dev *dev=dev_id;
 	u8 intr;
-	static volatile int locker=0;
+	static int locker;
 	int work=0;
 	struct z8530_irqhandler *irqs;
 	
-- 
2.8.1


  parent reply	other threads:[~2021-06-14 11:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 11:28 [PATCH V2 net-next 00/11] net: z85230: clean up some code style issues Guangbin Huang
2021-06-14 11:28 ` [PATCH V2 net-next 01/11] net: z85230: remove redundant blank lines Guangbin Huang
2021-06-14 11:28 ` [PATCH V2 net-next 02/11] net: z85230: add blank line after declarations Guangbin Huang
2021-06-14 11:28 ` [PATCH V2 net-next 03/11] net: z85230: fix the code style issue about EXPORT_SYMBOL(foo) Guangbin Huang
2021-06-14 11:28 ` Guangbin Huang [this message]
2021-06-14 11:28 ` [PATCH V2 net-next 05/11] net: z85230: replace comparison to NULL with "!skb" Guangbin Huang
2021-06-14 11:28 ` [PATCH V2 net-next 06/11] net: z85230: fix the comments style issue Guangbin Huang
2021-06-14 11:28 ` [PATCH V2 net-next 07/11] net: z85230: fix the code style issue about "if..else.." Guangbin Huang
2021-06-14 11:28 ` [PATCH V2 net-next 08/11] net: z85230: remove trailing whitespaces Guangbin Huang
2021-06-14 11:28 ` [PATCH V2 net-next 09/11] net: z85230: add some required spaces Guangbin Huang
2021-06-14 11:28 ` [PATCH V2 net-next 10/11] net: z85230: fix the code style issue about open brace { Guangbin Huang
2021-06-14 11:28 ` [PATCH V2 net-next 11/11] net: z85230: remove unnecessary out of memory message Guangbin Huang
2021-06-14 13:04 ` [PATCH V2 net-next 00/11] net: z85230: clean up some code style issues huangguangbin (A)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1623670131-49973-5-git-send-email-huangguangbin2@huawei.com \
    --to=huangguangbin2@huawei.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipeng321@huawei.com \
    --cc=ms@dev.tdt.de \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    --cc=xie.he.0141@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®