From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E6BC2BBFD for ; Sat, 11 Apr 2020 16:39:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10AEE20757 for ; Sat, 11 Apr 2020 16:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbgDKQjQ (ORCPT ); Sat, 11 Apr 2020 12:39:16 -0400 Received: from smtprelay0019.hostedemail.com ([216.40.44.19]:43110 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726257AbgDKQjQ (ORCPT ); Sat, 11 Apr 2020 12:39:16 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 5FD0718029126; Sat, 11 Apr 2020 16:39:16 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: songs44_1699a1ced6313 X-Filterd-Recvd-Size: 1699 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Sat, 11 Apr 2020 16:39:15 +0000 (UTC) Message-ID: <16239d86d8177e70f15aab5e7dca61758a749fb0.camel@perches.com> Subject: Re: [trivial PATCH] um virtio: Neaten vu_err macro definition From: Joe Perches To: Jeff Dike , Richard Weinberger , Anton Ivanov Cc: Erel Geron , linux-um@lists.infradead.org, linux-kernel Date: Sat, 11 Apr 2020 09:37:10 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-04-11 at 09:28 -0700, Joe Perches wrote: > Defining a macro with ... and __VA_ARGS__ (without ##) can cause > compilation errors if a macro use does not have additional args. > > Add ## to __VA_ARGS__ in the macro definition. [] > diff --git a/arch/um/drivers/virtio_uml.c b/arch/um/drivers/virtio_uml.c [] > @@ -74,7 +74,7 @@ struct virtio_uml_vq_info { > > extern unsigned long long physmem_size, highmem; > > -#define vu_err(vu_dev, ...) dev_err(&(vu_dev)->pdev->dev, __VA_ARGS__) > +#define vu_err(vu_dev, ...) dev_err(&(vu_dev)->pdev->dev, ##__VA_ARGS__) Ignore this. Caffeine-free so far this morning. It _might_ be better as: #define vu_err(vu_dev, fmt, ...) dev_err(&(vu_dev)->pdev->dev, fmt, ##__VA_ARGS__)