mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: kernel@collabora.com, linux-arm-kernel@lists.infradead.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Drop invalid clock-names from es8388 codec nodes
Date: Mon, 21 Oct 2024 21:50:56 +0300	[thread overview]
Message-ID: <1624395d-f4e9-4c82-a5ef-c05e2f3505db@collabora.com> (raw)
In-Reply-To: <172953337556.748331.14779753664880128918.robh@kernel.org>

On 10/21/24 8:58 PM, Rob Herring (Arm) wrote:
> 
> On Sat, 19 Oct 2024 03:38:10 +0300, Cristian Ciocaltea wrote:
>> The binding for Everest ES8328/ES8388 audio CODEC doesn't support the
>> 'clock-names' property:
>>
>>   rk3588-orangepi-5-plus.dtb: audio-codec@11: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>>     from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml#
>>
>> Since the related audio driver is also not making use of it, drop the
>> invalid property from all es8388 codec nodes.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>> Several DT fixes involving the usage of the Everest ES8328/ES8388 audio
>> CODEC.
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts      | 1 -
>>  arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts  | 1 -
>>  arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts      | 1 -
>>  arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 1 -
>>  4 files changed, 4 deletions(-)
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y rockchip/rk3399-roc-pc-plus.dtb rockchip/rk3588-orangepi-5-plus.dtb rockchip/rk3588-quartzpro64.dtb rockchip/rk3588s-indiedroid-nova.dtb' for 20241019-es8328-dt-fixes-v1-1-ca77d5ce21ad@collabora.com:
> 
> arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dtb: audio-codec@11: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml#
 
This warning is unrelated, but eventually fixed via:

https://lore.kernel.org/lkml/20241019-es8328-doc-port-v1-1-25c1d1b5c65c@collabora.com/

Regards,
Cristian

      reply	other threads:[~2024-10-21 18:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-19  0:38 Cristian Ciocaltea
2024-10-21 15:44 ` Heiko Stuebner
2024-10-21 17:58 ` Rob Herring (Arm)
2024-10-21 18:50   ` Cristian Ciocaltea [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1624395d-f4e9-4c82-a5ef-c05e2f3505db@collabora.com \
    --to=cristian.ciocaltea@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®