From: "tip-bot2 for Peter Zijlstra" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
Joerg Roedel <jroedel@suse.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: locking/core] lockdep: Fix wait-type for empty stack
Date: Wed, 23 Jun 2021 08:19:08 -0000 [thread overview]
Message-ID: <162443634860.395.11121182103864508829.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210617190313.256987481@infradead.org>
The following commit has been merged into the locking/core branch of tip:
Commit-ID: f8b298cc39f0619544c607eaef09fd0b2afd10f3
Gitweb: https://git.kernel.org/tip/f8b298cc39f0619544c607eaef09fd0b2afd10f3
Author: Peter Zijlstra <peterz@infradead.org>
AuthorDate: Thu, 17 Jun 2021 20:57:18 +02:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 22 Jun 2021 16:42:08 +02:00
lockdep: Fix wait-type for empty stack
Even the very first lock can violate the wait-context check, consider
the various IRQ contexts.
Fixes: de8f5e4f2dc1 ("lockdep: Introduce wait-type checks")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Joerg Roedel <jroedel@suse.de>
Link: https://lore.kernel.org/r/20210617190313.256987481@infradead.org
---
kernel/locking/lockdep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 6ff1e84..0584b20 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -4688,7 +4688,7 @@ static int check_wait_context(struct task_struct *curr, struct held_lock *next)
u8 curr_inner;
int depth;
- if (!curr->lockdep_depth || !next_inner || next->trylock)
+ if (!next_inner || next->trylock)
return 0;
if (!next_outer)
next prev parent reply other threads:[~2021-06-23 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 18:57 [PATCH 0/3] lockdep: PROVE_RAW_LOCK_NESTING=y fixes Peter Zijlstra
2021-06-17 18:57 ` [PATCH 1/3] lockdep: Fix wait-type for empty stack Peter Zijlstra
2021-06-23 8:19 ` tip-bot2 for Peter Zijlstra [this message]
2021-06-17 18:57 ` [PATCH 2/3] lockdep/selftests: Fix selftests vs PROVE_RAW_LOCK_NESTING Peter Zijlstra
2021-06-23 8:19 ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2021-06-17 18:57 ` [PATCH 3/3] lockdep/selftest: Remove wait-type RCU_CALLBACK tests Peter Zijlstra
2021-06-23 8:19 ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2021-06-18 9:23 ` [PATCH 0/3] lockdep: PROVE_RAW_LOCK_NESTING=y fixes Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162443634860.395.11121182103864508829.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®