mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Frank Cusack <fcusack@fcusack.com>
Cc: torvalds@osdl.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: effect of nfs blocksize on I/O ?
Date: Tue, 30 Sep 2003 02:04:05 -0400	[thread overview]
Message-ID: <16249.7381.602508.450922@charged.uio.no> (raw)
In-Reply-To: <20030929222345.A3043@google.com>

>>>>> " " == Frank Cusack <fcusack@fcusack.com> writes:

     > Then it sounds like the current wtmult/512 value for f_bsize is
     > a bug.  Until such time as you get f_frsize going, just
     > directly plugging wsize into s_blocksize seems like a win.
     > Doesn't it?

No "until such time" solutions please... Let's do it right the first
time, or not at all!

s_blocksize should remain set to wtmult. It is only f_bsize and
f_frsize that are currently set to the wrong values.

     > ISTM that f_frsize is pretty useless for NFS.  Even if the
     > server gives you this value (as wtmult), what use besides
     > conversion of tbytes/abytes values does it have?

As I told you, the main use is for 'df' and friends. Get it wrong, and
the result will be rounding errors when reporting disk sizes etc. This
is currently the case in 2.4.x where we confuse f_bsize and f_frsize.

Cheers,
  Trond

      reply	other threads:[~2003-09-30  6:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-29  6:42 Frank Cusack
2003-09-29  7:19 ` Trond Myklebust
2003-09-29  7:52   ` Frank Cusack
2003-09-29  8:27     ` Trond Myklebust
2003-09-30  5:23       ` Frank Cusack
2003-09-30  6:04         ` Trond Myklebust [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16249.7381.602508.450922@charged.uio.no \
    --to=trond.myklebust@fys.uio.no \
    --cc=fcusack@fcusack.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®