From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
To: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<sudeep.holla@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <james.morse@arm.com>,
<wangxiongfeng2@huawei.com>
Subject: [PATCH] cacheinfo: clear cache_leaves(cpu) in free_cache_attributes()
Date: Tue, 13 Jul 2021 11:47:38 +0800 [thread overview]
Message-ID: <1626148058-55230-1-git-send-email-wangxiongfeng2@huawei.com> (raw)
On ARM64, when PPTT(Processor Properties Topology Table) is not
implemented in ACPI boot, we will goto 'free_ci' with the following
print:
Unable to detect cache hierarchy for CPU 0
But some other codes may still use 'num_leaves' to iterate through the
'info_list', such as get_cpu_cacheinfo_id(). If 'info_list' is NULL , it
would crash. So clear 'num_leaves' in free_cache_attributes().
Fixes: 246246cbde5e ("drivers: base: support cpu cache information
interface to userspace via sysfs")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
---
drivers/base/cacheinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
index bfc0959..dad2962 100644
--- a/drivers/base/cacheinfo.c
+++ b/drivers/base/cacheinfo.c
@@ -297,6 +297,7 @@ static void free_cache_attributes(unsigned int cpu)
kfree(per_cpu_cacheinfo(cpu));
per_cpu_cacheinfo(cpu) = NULL;
+ cache_leaves(cpu) = 0;
}
int __weak init_cache_level(unsigned int cpu)
--
1.7.12.4
next reply other threads:[~2021-07-13 3:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 3:47 Xiongfeng Wang [this message]
2021-07-13 11:33 ` Sudeep Holla
2021-07-13 12:46 ` Xiongfeng Wang
2021-07-13 13:26 ` Sudeep Holla
2021-07-13 17:38 ` James Morse
2021-07-13 17:48 ` Sudeep Holla
2021-07-13 17:50 ` Sudeep Holla
2021-07-14 11:01 ` Xiongfeng Wang
2021-07-14 2:10 ` Xiongfeng Wang
2021-07-14 17:13 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1626148058-55230-1-git-send-email-wangxiongfeng2@huawei.com \
--to=wangxiongfeng2@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®