From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15881283FF9; Mon, 20 Oct 2025 16:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.155.224.40 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760976093; cv=none; b=Rc/VBgq0B4iiFyyDA15N/kutEjzKttHSCXDAPxyMFdqcIQW4boKJCl/9G+8XGNUKS5ld+CApno7mHvWVte1sv9lswFeDFWUjQmD5AuAtKiWOiyM9XYEaDJ0lIkphNQXfOAi6F3nw2Urfe4CYOp0i7OvtJmFa9Uq4vgzgTlsPoOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760976093; c=relaxed/simple; bh=6UAYYbRl6gVxoWFWJmquglKp4qMFnwIKcWIe1rtXLbg=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=T289z1O8g+K4LDJbEQFzr1vf5LWmJx6Z4/c7OT0KgNuiptlYRmRlFYeqW2zQzj3xKv/65fR9MUhVHbCTtiXvt0F9hHKG23bExf12qxp4H5ieI77kuM+uqgra3B/rYyMX/bk8Kuzvzv+idc0vqhJKt7bIkparx6kBtpJucS49xp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=raptorengineering.com; spf=pass smtp.mailfrom=raptorengineering.com; dkim=pass (1024-bit key) header.d=raptorengineering.com header.i=@raptorengineering.com header.b=QNkQ3EIZ; arc=none smtp.client-ip=23.155.224.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=raptorengineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raptorengineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=raptorengineering.com header.i=@raptorengineering.com header.b="QNkQ3EIZ" Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 2641782854A5; Mon, 20 Oct 2025 11:01:31 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6o93uEcNXNI3; Mon, 20 Oct 2025 11:01:29 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 9A8B7828851D; Mon, 20 Oct 2025 11:01:29 -0500 (CDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 9A8B7828851D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1760976089; bh=9XOvRKZB3ZHxwazpGMcpCeHjuLjttzMXe5TLIp4gLwQ=; h=Date:From:To:Message-ID:MIME-Version; b=QNkQ3EIZlV+10wfyNPSUJwaX1AJh4R3JpucrJc8ooITpdIhyvJ7G1fmq8HYjisO3U wiNUHduXl6At9Xg1WnGkXm2iTI39JSILVTduAzaeiA9T3KPJ3tmKNvpQ9HmA9QbHa0 LR6xK9LY3dMenwsi+59F8E8iZcSGDJf7nuyuDeWQ= X-Virus-Scanned: amavisd-new at rptsys.com Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Mn7UjrjG7kFk; Mon, 20 Oct 2025 11:01:29 -0500 (CDT) Received: from vali.starlink.edu (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 6F9BD82854A5; Mon, 20 Oct 2025 11:01:29 -0500 (CDT) Date: Mon, 20 Oct 2025 11:01:26 -0500 (CDT) From: Timothy Pearson To: Krzysztof Kozlowski Cc: robh , devicetree , linux-kernel , Conor Dooley , Krzysztof Kozlowski , Lee Jones , Georgy Yakovlev Message-ID: <1626454153.1801886.1760976086710.JavaMail.zimbra@raptorengineeringinc.com> In-Reply-To: References: <948400747.1748562.1758824253627.JavaMail.zimbra@raptorengineeringinc.com> <20250929141113.GA3987541-robh@kernel.org> <924260297.1801829.1760974499327.JavaMail.zimbra@raptorengineeringinc.com> Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.5.0_GA_3042 (ZimbraWebClient - GC141 (Linux)/8.5.0_GA_3042) Thread-Topic: dt-bindings: mfd: Add sony,cronos-cpld Thread-Index: +XTYI2SaT+vzvvqrHcY8ELCXWJUT7g== ----- Original Message ----- > From: "Krzysztof Kozlowski" > To: "Timothy Pearson" , "robh" > Cc: "devicetree" , "linux-kernel" , "Conor Dooley" > , "Krzysztof Kozlowski" , "Lee Jones" , "Georgy > Yakovlev" , "Shawn Anastasio" > Sent: Monday, October 20, 2025 10:58:40 AM > Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld > On 20/10/2025 17:34, Timothy Pearson wrote: >>>> + watchdog: >>>> + type: object >>>> + description: Cronos Platform Watchdog Timer >>>> + >>>> + allOf: >>>> + - $ref: watchdog.yaml# >>>> + >>>> + properties: >>>> + compatible: >>>> + const: sony,cronos-watchdog >>> >>> There's no need for a child node here. 'timeout-sec' can just go in the >>> parent node. >> >> Could you elaborate on this please? As far as I can tell we ref watchdog.yaml >> and need some kind of compatible string, so why would I break out timeout-sec >> directly here? > > > Please look where the comment was placed. Under $ref? No. Under this > compatible. $ref goes to the parent, obviously. This is not an area of the kernel I'm normally changing, so I appreciate the insight. None of this yaml syntax is particularly obvious the first time it's encountered, at least not to me. > You do not need kind of compatible string. Parent already has one. You > do not need compatible strings at all to instantiate Linux drivers. > That's pretty common pattern for most of MFD-like devices, plenty of > examples in the kernel. Understood.