From: Saeed Mahameed <saeed@kernel.org>
To: George Cherian <george.cherian@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Pirko <jiri@nvidia.com>
Cc: kuba@kernel.org, davem@davemloft.net, sgoutham@marvell.com,
lcherian@marvell.com, gakula@marvell.com, masahiroy@kernel.org,
willemdebruijn.kernel@gmail.com
Subject: Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX
Date: Wed, 04 Nov 2020 21:08:52 -0800 [thread overview]
Message-ID: <1627a52089f421c8594c9a99fd9137caa6485572.camel@kernel.org> (raw)
In-Reply-To: <20201104122755.753241-4-george.cherian@marvell.com>
On Wed, 2020-11-04 at 17:57 +0530, George Cherian wrote:
> Add health reporters for RVU NPA block.
^^^ NIX ?
Cc: Jiri
Anyway, could you please spare some words on what is NPA and what is
NIX?
Regarding the reporters names, all drivers register well known generic
names such as (fw,hw,rx,tx), I don't know if it is a good idea to use
vendor specific names, if you are reporting for hw/fw units then just
use "hw" or "fw" as the reporter name and append the unit NPA/NIX to
the counter/error names.
> Only reporter dump is supported.
>
> Output:
> # ./devlink health
> pci/0002:01:00.0:
> reporter npa
> state healthy error 0 recover 0
> reporter nix
> state healthy error 0 recover 0
> # ./devlink health dump show pci/0002:01:00.0 reporter nix
> NIX_AF_GENERAL:
> Memory Fault on NIX_AQ_INST_S read: 0
> Memory Fault on NIX_AQ_RES_S write: 0
> AQ Doorbell error: 0
> Rx on unmapped PF_FUNC: 0
> Rx multicast replication error: 0
> Memory fault on NIX_RX_MCE_S read: 0
> Memory fault on multicast WQE read: 0
> Memory fault on mirror WQE read: 0
> Memory fault on mirror pkt write: 0
> Memory fault on multicast pkt write: 0
> NIX_AF_RAS:
> Poisoned data on NIX_AQ_INST_S read: 0
> Poisoned data on NIX_AQ_RES_S write: 0
> Poisoned data on HW context read: 0
> Poisoned data on packet read from mirror buffer: 0
> Poisoned data on packet read from mcast buffer: 0
> Poisoned data on WQE read from mirror buffer: 0
> Poisoned data on WQE read from multicast buffer: 0
> Poisoned data on NIX_RX_MCE_S read: 0
> NIX_AF_RVU:
> Unmap Slot Error: 0
>
Now i am a little bit skeptic here, devlink health reporter
infrastructure was never meant to deal with dump op only, the main
purpose is to diagnose/dump and recover.
especially in your use case where you only report counters, i don't
believe devlink health dump is a proper interface for this.
Many of these counters if not most are data path packet based and maybe
they should belong to ethtool.
next prev parent reply other threads:[~2020-11-05 5:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 12:27 [PATCH v2 net-next 0/3] Add devlink and devlink health reporters to George Cherian
2020-11-04 12:27 ` [PATCH v2 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver George Cherian
2020-11-04 12:27 ` [PATCH v2 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA George Cherian
2020-11-04 12:27 ` [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX George Cherian
2020-11-05 5:08 ` Saeed Mahameed [this message]
2020-11-05 13:36 George Cherian
2020-11-05 17:07 ` Jakub Kicinski
2020-11-05 19:23 ` Saeed Mahameed
2020-11-05 20:42 ` Jakub Kicinski
2020-11-05 23:52 ` Saeed Mahameed
2020-11-06 0:23 ` Jakub Kicinski
2020-11-05 19:15 ` Saeed Mahameed
2020-11-05 19:29 ` Sunil Kovvuri
2020-11-06 20:58 ` Saeed Mahameed
2020-11-07 15:51 ` Sunil Kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1627a52089f421c8594c9a99fd9137caa6485572.camel@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=gakula@marvell.com \
--cc=george.cherian@marvell.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgoutham@marvell.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®