Re: Linux 2.4.23-pre8

[Trond Myklebust <trond.myklebust@fys.uio.no>]

>>>>> " " == Philipp Matthias Hahn <pmhahn@titan.lahn.de> writes:

     > make[3]: Entering directory `/usr/src/linux-2.4.23/net/sunrpc'
     > gcc -D__KERNEL__ -I/usr/src/linux-2.4.23/include -Wall
     > -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
     > -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686
     > -fno-optimize-sibling-calls -DMODULE -nostdinc -iwithprefix
     > include -DKBUILD_BASENAME=clnt -c -o clnt.o clnt.c clnt.c: In
     > function `call_verify': clnt.c:946: error: duplicate case value
     > clnt.c:926: error: previously used here clnt.c:951: error:
     > duplicate case value clnt.c:937: error: previously used here

There are no duplicate cases for the pre8 I just downloaded from
BitKeeper. Are you sure you haven't screwed up the patches?

Cheers,
  Trond

NOTE: The code in question should look as follows:

        switch ((n = ntohl(*p++))) {
        case RPC_SUCCESS:
                return p;
        case RPC_PROG_UNAVAIL:
                printk(KERN_WARNING "RPC: call_verify: program %u is unsupported by server %s\n",
                                (unsigned int)task->tk_client->cl_prog,
                                task->tk_client->cl_server);
                goto out_eio;
        case RPC_PROG_MISMATCH:
                printk(KERN_WARNING "RPC: call_verify: program %u, version %u unsupported by server %s\n",
                                (unsigned int)task->tk_client->cl_prog,
                                (unsigned int)task->tk_client->cl_vers,
                                task->tk_client->cl_server);
                goto out_eio;
        case RPC_PROC_UNAVAIL:
                printk(KERN_WARNING "RPC: call_verify: proc %u unsupported by program %u, version %u on server %s\n",
                                (unsigned int)task->tk_msg.rpc_proc,
                                (unsigned int)task->tk_client->cl_prog,
                                (unsigned int)task->tk_client->cl_vers,
                                task->tk_client->cl_server);
                goto out_eio;
        case RPC_GARBAGE_ARGS:
                break;                  /* retry */
        default:
                printk(KERN_WARNING "call_verify: server accept status: %x\n", n);
                /* Also retry */
        }