From: Maninder Singh <maninder1.s@samsung.com>
To: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
mark.rutland@arm.com, joey.gouly@arm.com, maz@kernel.org,
pcc@google.com, amit.kachhap@arm.com, ryabinin.a.a@gmail.com,
dvyukov@google.com, akpm@linux-foundation.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
v.narang@samsung.com, a.sahrawat@samsung.com,
Maninder Singh <maninder1.s@samsung.com>
Subject: [PATCH 1/1] exception/stackdepot: add irqentry section in case of STACKDEPOT
Date: Wed, 18 Aug 2021 12:45:43 +0530 [thread overview]
Message-ID: <1629270943-9304-1-git-send-email-maninder1.s@samsung.com> (raw)
In-Reply-To: <CGME20210818071602epcas5p4fecf459638312c95c5d5aaa29e7e983a@epcas5p4.samsung.com>
As of now if CONFIG_FUNCTION_GRAPH_TRACER is disabled some functions
like gic_handle_irq will not be added in irqentry text section.
which leads to adding more stacks in stackdepot as frames below IRQ
will not be filtered with filter_irq_stack() function.
checked with debug interface for satckdepot:
https://lkml.org/lkml/2017/11/22/242
e.g. (ARM)
stack count 23188 backtrace
prep_new_page+0x14c/0x160
get_page_from_freelist+0x1258/0x1350
...
__handle_domain_irq+0x1ac/0x4ac
gic_handle_irq+0x44/0x80
__irq_svc+0x5c/0x98
__slab_alloc.constprop.0+0x84/0xac
__kmalloc+0x31c/0x340
sf_malloc+0x14/0x18
and for same _irq_svc there were 25000 calls which was causing
memory pressure of 2MB more on satckdepot, which will keep increasing.
Before patch memory consumption on ARM target after 2 hours:
Memory consumed by Stackdepot:3600 KB
After change:
============
Memory consumed by Stackdepot:1744 KB
prep_new_page+0x14c/0x160
get_page_from_freelist+0x2e4/0x1350
...
__handle_domain_irq+0x1ac/0x4ac
gic_handle_irq+0x44/0x80
^^^^^ no frames below this.
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Signed-off-by: Vaneet Narang <v.narang@samsung.com>
---
arch/arm/include/asm/exception.h | 2 +-
arch/arm64/include/asm/exception.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/exception.h b/arch/arm/include/asm/exception.h
index 58e039a851af..3f4534cccc0f 100644
--- a/arch/arm/include/asm/exception.h
+++ b/arch/arm/include/asm/exception.h
@@ -10,7 +10,7 @@
#include <linux/interrupt.h>
-#ifdef CONFIG_FUNCTION_GRAPH_TRACER
+#if defined(CONFIG_FUNCTION_GRAPH_TRACER) || defined(CONFIG_STACKDEPOT)
#define __exception_irq_entry __irq_entry
#else
#define __exception_irq_entry
diff --git a/arch/arm64/include/asm/exception.h b/arch/arm64/include/asm/exception.h
index 339477dca551..ef2581b63405 100644
--- a/arch/arm64/include/asm/exception.h
+++ b/arch/arm64/include/asm/exception.h
@@ -13,7 +13,7 @@
#include <linux/interrupt.h>
-#ifdef CONFIG_FUNCTION_GRAPH_TRACER
+#if defined(CONFIG_FUNCTION_GRAPH_TRACER) || defined(CONFIG_STACKDEPOT)
#define __exception_irq_entry __irq_entry
#else
#define __exception_irq_entry __kprobes
--
2.17.1
next parent reply other threads:[~2021-08-18 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210818071602epcas5p4fecf459638312c95c5d5aaa29e7e983a@epcas5p4.samsung.com>
2021-08-18 7:15 ` Maninder Singh [this message]
[not found] ` <CGME20210818071602epcas5p4fecf459638312c95c5d5aaa29e7e983a@epcms5p6>
2021-09-06 12:43 ` Maninder Singh
2021-09-06 12:57 ` Russell King (Oracle)
[not found] ` <CGME20210818071602epcas5p4fecf459638312c95c5d5aaa29e7e983a@epcms5p4>
2021-09-10 12:59 ` Maninder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629270943-9304-1-git-send-email-maninder1.s@samsung.com \
--to=maninder1.s@samsung.com \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=amit.kachhap@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=joey.gouly@arm.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=pcc@google.com \
--cc=ryabinin.a.a@gmail.com \
--cc=v.narang@samsung.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®