From: Zhenguo Zhao <zhenguo6858@gmail.com>
To: nianfu.bai@unisoc.com, gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/8] tty: n_gsm: Modify cr bit value when config requester
Date: Fri, 20 Aug 2021 20:17:46 +0800 [thread overview]
Message-ID: <1629461872-26965-2-git-send-email-zhenguo6858@gmail.com> (raw)
In-Reply-To: <1629461872-26965-1-git-send-email-zhenguo6858@gmail.com>
From: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>
When n_gsm config "initiator=0",as requester,gsmld will receive dlci
SABM and DISC control command frame,the CR bit value should be 1.
If cr == 0,it will goto invalid,and it can't send UA response
frame and open requster dlci.
case SABM|PF:
- if (cr == 0)
+ if (cr == 0) {
+ printk("gsm_queue invalid\n");
goto invalid;
+ }
Example,gsmld receive dlc0 SABM command frame:f9 03 3f 01 1c f9
but gsmld goto invalid.
Kernel test log:
[ 101.794705] c0 gsmld_receive: 00000000: f9 03 3f 01 1c f9
[ 101.803341] c0 <-- 0) C: SABM(P)
[ 101.811371] c0 gsm_queue invalid
Signed-off-by: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>
---
drivers/tty/n_gsm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 5fea02c..becca2c 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1779,7 +1779,7 @@ static void gsm_queue(struct gsm_mux *gsm)
switch (gsm->control) {
case SABM|PF:
- if (cr == 0)
+ if (cr == 1)
goto invalid;
if (dlci == NULL)
dlci = gsm_dlci_alloc(gsm, address);
@@ -1793,7 +1793,7 @@ static void gsm_queue(struct gsm_mux *gsm)
}
break;
case DISC|PF:
- if (cr == 0)
+ if (cr == 1)
goto invalid;
if (dlci == NULL || dlci->state == DLCI_CLOSED) {
gsm_response(gsm, address, DM);
--
1.9.1
next prev parent reply other threads:[~2021-08-20 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 12:17 [PATCH 1/8] tty: n_gsm: Add some instructions and code for requester Zhenguo Zhao
2021-08-20 12:17 ` Zhenguo Zhao [this message]
2021-08-20 12:17 ` [PATCH 3/8] tty: n_gsm: Modify CR,PF bit when config requester Zhenguo Zhao
2021-08-20 12:17 ` [PATCH 4/8] tty: n_gsm: Modify CR,PF bit printk info " Zhenguo Zhao
2021-08-20 12:17 ` [PATCH 5/8] tty: n_gsm: Delete gsm_disconnect " Zhenguo Zhao
2021-08-20 12:17 ` [PATCH 6/8] tty: n_gsm: Delete gsmtty open SABM frame " Zhenguo Zhao
2021-08-20 12:17 ` [PATCH 7/8] tty: n_gsm: Modify gsmtty driver register method " Zhenguo Zhao
2021-08-20 12:17 ` [PATCH 8/8] tty: n_gsm: Save dlci address open status " Zhenguo Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629461872-26965-2-git-send-email-zhenguo6858@gmail.com \
--to=zhenguo6858@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nianfu.bai@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®