From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBos2JjifDsmHqRnpbXg2w/gYL/JmEMkqF2Sqqc7kIYv5pFp/HS6uneTn7UYsc28Cj/KCkXNU ARC-Seal: i=1; a=rsa-sha256; t=1516293362; cv=none; d=google.com; s=arc-20160816; b=TjasGR6FoxUE+WZC/0eFT58AgkGtb5ntlAJRa/E3x5Nvoh3/+Js2gNJSP9//16LAPq YH/+XJaq//9xRGIBiFSalkdWLh9gQZNWypWKVT5CPjo48vPPCh5BgSRqFI/crtZswgul v87N9HwURHAD3PL7r3GdpnU2IZpB7k44pvdLmHLpud8TA9zxFHtF6222LBj1EPaGtfyt KWoo1mOfYVJGGJfn5b+DTo4l6qfvO5x7pXJ2ljnJlMEg+Ir93/Dc9phYsUIkDQ+BgEG7 Oo/YtfE8yT5YRNRffY6/2dDgsijTII8wPYpOh9iiR+AGcMK3GKVeX/Abhu/JGJfF+3PK Or8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=koovqXn56zb8Kuy/BN8QwhxIXFxeELdZMNYI2iwgBZQ=; b=DWiT5drU/COHLBAHeBGnbUKe71nnMQqmu/eEHU2v5bNpWFxRfiqXo8PSGW4BaaeMsW zjoaLGWCvbYLj6AWgLeBYWJ5xPZCSBM83JGxcZ3D78arygPNhjjBvkZNAhQpjlYTjRjt mWN0PBDXfNGCaAHyHR+gdC6AcNuzVO2oJo55ZuI/aEN7EMKiwaD9ZbO7nbKgqEk0EzVy 51ccMDJ2WzlfUGlhqQad22oMsaX6JYWyMg6hro1OPeZPAEkX9Hqc/othwE91i2ZwhUi6 LtkVaSuDgnrg7uPnZKFbuuYtAz8KnB4OS7/15yHD2cBIYWCRhFEc9xdG5JRh3Zjf/cP4 HfwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=mxb7vNyY; dkim=pass header.i=@codeaurora.org header.s=default header.b=JZN71Ta/; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=mxb7vNyY; dkim=pass header.i=@codeaurora.org header.s=default header.b=JZN71Ta/; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 748AC601CF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v5 4/4] PCI/DPC: Enumerate the devices after DPC trigger event To: poza@codeaurora.org, Keith Busch Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Wei Zhang , Timur Tabi References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-5-git-send-email-poza@codeaurora.org> <20180118025615.GF7562@localhost.localdomain> <153733e36c151d2a549b814e4232c0df@codeaurora.org> From: Sinan Kaya Message-ID: <1629ca15-81f6-f5f4-8f9c-d0a575272dd6@codeaurora.org> Date: Thu, 18 Jan 2018 11:35:59 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <153733e36c151d2a549b814e4232c0df@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835695085239135?= X-GMAIL-MSGID: =?utf-8?q?1589948828901175078?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 1/18/2018 12:32 AM, poza@codeaurora.org wrote: > On 2018-01-18 08:26, Keith Busch wrote: >> On Wed, Jan 17, 2018 at 08:27:39AM -0800, Sinan Kaya wrote: >>> On 1/17/2018 5:37 AM, Oza Pawandeep wrote: >>> > +static bool dpc_wait_link_active(struct pci_dev *pdev) >>> > +{ >>> >>> I think you can also make this function common instead of making another copy here. >>> Of course, this would be another patch. >> >> It is actually very similar to __pcie_wait_link_active in pciehp_hpc.c, >> so there's some opprotunity to make even more common code. > > in that case there has to be a generic function in > drives/pci.c > > which addresses folowing functions from > > pcie-dpc.c: > dpc_wait_link_inactive > dpc_wait_link_active > > drivers/pci/hotplug/pciehp_hpc.c > pcie_wait_link_active > > > all aboe making one generic function to be moved to drives/pci.c > > please let me know if this is okay. Works for me. Keith/Bjorn? > > Regards, > Oza. > > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.