From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: wangjianli <wangjianli@cdjrlc.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mptcp: fix repeated words in comments
Date: Mon, 24 Oct 2022 15:04:28 -0700 (PDT) [thread overview]
Message-ID: <162b5545-7d24-3cf2-9158-3100ef644e03@linux.intel.com> (raw)
In-Reply-To: <Y1VF1DBYePbkTk8x@debian.me>
On Sun, 23 Oct 2022, Bagas Sanjaya wrote:
> On Sat, Oct 22, 2022 at 03:05:27PM +0800, wangjianli wrote:
>> Delete the redundant word 'the'.
>>
>> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
>> ---
>> net/mptcp/token.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
>> index f52ee7b26aed..b817c2564300 100644
>> --- a/net/mptcp/token.c
>> +++ b/net/mptcp/token.c
>> @@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
>> * This function returns the first mptcp connection structure found inside the
>> * token container starting from the specified position, or NULL.
>> *
>> - * On successful iteration, the iterator is move to the next position and the
>> + * On successful iteration, the iterator is move to the next position and
>> * the acquires a reference to the returned socket.
>> */
>> struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,
>
> NAK!
>
> Instead, slightly reword the comment above as "On successful iteration,
> the iterator moves to the next position and acquires a reference to the
> returned socket.".
>
Agree on this rewording.
This particular duplicated word came up before, and I thought it would be
best if the author sent a v2 - but they never did. I will fix this in the
MPTCP tree next week if there's no suitable v2 by then.
--
Mat Martineau
Intel
prev parent reply other threads:[~2022-10-24 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 7:05 wangjianli
2022-10-23 13:47 ` Bagas Sanjaya
2022-10-24 22:04 ` Mat Martineau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162b5545-7d24-3cf2-9158-3100ef644e03@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=bagasdotme@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangjianli@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®