From: Michal Simek <michal.simek@xilinx.com>
To: Dhaval Shah <dhaval.shah@xilinx.com>, <michal.simek@xilinx.com>,
<pombredanne@nexb.com>, <tglx@linutronix.de>,
<kstewart@linuxfoundation.org>, <gregkh@linuxfoundation.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Dhaval Shah <dshah@xilinx.com>
Subject: Re: [PATCH] soc: xilinx: xlnx_vcu: Depends on HAS_IOMEM for xlnx_vcu
Date: Tue, 16 Jan 2018 08:35:26 +0100 [thread overview]
Message-ID: <162bd4c1-6125-f856-85b1-6ee2d69ac7ec@xilinx.com> (raw)
In-Reply-To: <1516084488-16372-1-git-send-email-dshah@xilinx.com>
On 16.1.2018 07:34, Dhaval Shah wrote:
> xlnx_vcu driver uses devm_ioremap_nocache, which is included
> only when HAS_IOMEM is enabled.
>
> drivers/soc/xilinx/xlnx_vcu.o: In function `xvcu_probe':
> xlnx_vcu.c:(.text+0x116): undefined reference to `devm_ioremap_nocache'
> xlnx_vcu.c:(.text+0x1ae): undefined reference to `devm_ioremap_nocache'
>
> Signed-off-by: Dhaval Shah <dshah@xilinx.com>
> ---
> drivers/soc/xilinx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/xilinx/Kconfig b/drivers/soc/xilinx/Kconfig
> index 266b50f..bf657ab 100644
> --- a/drivers/soc/xilinx/Kconfig
> +++ b/drivers/soc/xilinx/Kconfig
> @@ -3,6 +3,7 @@ menu "Xilinx SoC drivers"
>
> config XILINX_VCU
> tristate "Xilinx VCU logicoreIP Init"
> + depends on HAS_IOMEM
> help
> Provides the driver to enable and disable the isolation between the
> processing system and programmable logic part by using the logicoreIP
>
Applied.
Thanks,
Michal
prev parent reply other threads:[~2018-01-16 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201801141754.lROQHRMR%fengguang.wu@intel.com>
2018-01-16 6:34 ` Dhaval Shah
2018-01-16 7:35 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162bd4c1-6125-f856-85b1-6ee2d69ac7ec@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=dhaval.shah@xilinx.com \
--cc=dshah@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®