From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 023F2175A91 for ; Fri, 19 Jun 2026 13:03:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781874213; cv=none; b=oK7ScjjjKPMwFPL2NUn/RYOy0KU5A7g8tcYXHJFqgXPR4ZDBj/5Pcq9SO6fx/Z/bRcF8ipaafoeR81XrOy2ucLHbNelRnhoK3qEIjw4hPveJyEIv96UL0xjsR13x5KO+MVQWKzsbbgg1Dsc+poau/sHgpl9LcLdCL5Hw+kaR5wo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781874213; c=relaxed/simple; bh=3mCTWcfWvUyyK0fH+VyZ3gkqM2ROnFmpTZn7EBA39dE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eWTWjQb0dk3DS6Lre46O5rTKugBDecVHa7At6xqlUHs+zs5yRS6pYbF0TXTZn2MHzCnWm7hvUfg2K7w+wQC2x1qNLWEhYAkSL8Ke9lFUrqChbp9lHoBMlRZMO3WkF93GAm+ypQG4RmbtjDtPOVHDHXVq/RjDFpvgKpyDd/1z+lw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n/qEWSCT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aTqOHto0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n/qEWSCT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aTqOHto0" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65J7Q85R4185058 for ; Fri, 19 Jun 2026 13:03:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sFCXHDvwe96hDuMd6utugZ6UnfSu1p+eODGwnzreykQ=; b=n/qEWSCTbN6v38co epWAJTEeor987ii8LyfuvtA/NDPH15XbGBz1eMfTT4z7RZmIq6sSjLFZaDZUyC+U dUgmkYWLg6u3aEGj4aBYoab9m3N1Gifity+rqrKeUuNgvC10hXxA1lypCo0bI0f1 z3zlodAa9CdG3NWxCv7edEbigklslK2uAKM1fBO6muvAsQsRp4Zv9jBoRfNPdIld NpFjx3UlZP7e3neVV/4XBqdy2dXHmoOWjt2Son9riAOtx0+x2K0UY+jSOAOtqwf3 YSXXsmHgY2u6q0gTSpHTJ72bcJwO85yjPGIIa0GHVMeBZ6dzZDOvmvvCMoVCKZfy easMWg== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4evp6sbbsb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Jun 2026 13:03:29 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7e6b5741bbcso590997a34.1 for ; Fri, 19 Jun 2026 06:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781874209; x=1782479009; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sFCXHDvwe96hDuMd6utugZ6UnfSu1p+eODGwnzreykQ=; b=aTqOHto0P5k5aqoUfKxbKqcgiioTf/iJYhQdgYsbb4RmqVjtcAE+OAaiIlMhK19Fak Lrgl+Bok5V8qLFROf7zxSJw1BJE2FF3RUmaDJOGLq4FAUqHqTHA6JfkVm6GawvDWbmEj SOEmfI5Eq7/i/IM8TODJR7Cdd0Sb3l6/T+DgOoY63BfttAOlUZ8gjEt9CF/X4Dt++KAe zEDhEL93csWDAkUOUdh8EMe6IIsQu0NzHqsgwzpaMRbHn35o9qzJQw7b4yQjJ90m51JJ k5QHzrjSBRrBd1SB+sy22g6ZJfnapFi1biEGvXfAMuvSvdM4BZcnCZLrLS3EGUCqQOX4 EhIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781874209; x=1782479009; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sFCXHDvwe96hDuMd6utugZ6UnfSu1p+eODGwnzreykQ=; b=doMMUdKEseCOM4DB2gYMY+mEnRgiyDexK1rUcqyGEdOtPfZ+Mt3mHMp57duCUmv/5s zYDb8owvVyHwhhi3dsDFjr7d1pi0GowFCPBNEWHtGIC67jMVEnR0uVQBxiYIuriLe0nj 8o1T6F9eYqEX8iJUSFrbJdzwrTB7cG1BzZv5TWF3RrgfH2Ky22dbdK540/E2jKjWHh0z 9an3veqLBDgi4HKerLC8gZGyx8ccCSgBwiGotgv4AdRGPGT+7EjWJUlcpgiOQuf8Un9S PUBF1ThbVdWxEhJBMs+wmznSXsb6hvFOiguaduikysFgQ272nwF3YJEcFu4QSGVl1MMG XaVQ== X-Forwarded-Encrypted: i=1; AFNElJ+9lctBZkxg+ByMZGkD72yLmt4UmFwUpw5aK4q4OMOCKXUjTTc1moiKcy6PIcJicXfOZQDcQM+use/rRyc=@vger.kernel.org X-Gm-Message-State: AOJu0YxcfUI770vtljDe2wnuBpDozFBN6FUDRwXw0vvEvW/kC/4Qacpf /rJeNCYPV0rcsqMo5YztJFmgSNU9bdFlEq1URLo/OYE05uKdDumdNFfr+qzq3SqyzDEKaUQkRf7 jvUXH8yT6coykmfNX4OQ//ECDZRxFQ94dl/0oWBc3VTCM/b2X28++sAk4yELDZNegw8M= X-Gm-Gg: AfdE7clstk4tc0c0SdcBUfP/YbtLyz5O1beRfNNCO8/lSOjdBWGIi2StN1/SRnK1WzB CQ2NAEgsuDk1L9xa96eglYLrbQUT69N7UaeiGo/eZIhrcnE+ENoIrpFhQMoHlTjRje4rQ3QCg4f 66lLpCPUe+TKOZtdp7Oj9fBPdjjfv1MxorosV90ju30kkv1uBiD+0ehY/RI6e6xNymdje1lyoCj h5Q65VmLRuOGHl0x7S9OfJG2Sxt9y/eNZPEhtgoSGcgdmI0E2T/tmvfogZRrHVzt76VoL8+CqjN oMnhZojcaf+V+2y+lvBZn5GkwMOtTR0keDB3QxtIR0qHp608rmoZDTJIohUbxZ//Sh0Mz1U1FWO hMoqETXZkuXnnQ8Zdy6YRtklsOmCChFuv3wA= X-Received: by 2002:a05:6830:838b:b0:7db:c389:648d with SMTP id 46e09a7af769-7e92d47d882mr1423049a34.0.1781874209159; Fri, 19 Jun 2026 06:03:29 -0700 (PDT) X-Received: by 2002:a05:6830:838b:b0:7db:c389:648d with SMTP id 46e09a7af769-7e92d47d882mr1422886a34.0.1781874205309; Fri, 19 Jun 2026 06:03:25 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0a84b0a00csm88117566b.25.2026.06.19.06.03.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 06:03:24 -0700 (PDT) Message-ID: <162da512-1142-48fa-bf7d-0b2393467a75@oss.qualcomm.com> Date: Fri, 19 Jun 2026 15:03:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp: Add camera MCLK pinctrl To: Vladimir Zapolskiy , Pengyu Luo Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260607160435.36546-1-mitltlatltl@gmail.com> <280402c0-57bd-46a3-b95c-f9ae02122a09@oss.qualcomm.com> <423b4e86-3837-4d69-8f56-d8259be53ff5@oss.qualcomm.com> <12a89ab8-dc43-4b55-9c95-36d44c75dcab@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <12a89ab8-dc43-4b55-9c95-36d44c75dcab@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: eAXK6dAgVNnsJ43DA3ZIno2yE3sW2AFh X-Proofpoint-ORIG-GUID: eAXK6dAgVNnsJ43DA3ZIno2yE3sW2AFh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE5MDEyMiBTYWx0ZWRfX5oLCk/JX5dZ1 b3k3ZaDeQkrlkItKRoBa8Q0sOcjbev1oGz7h9OOFXaI5cMxAmCZ8Gxi1mCpFQ4JgFx740cCXPfu gVXmmmQJipWlenEi5mmUdVHEA7rG7KlPCHd90jZ8rBmxgMfnhN3p/u+aW50t1IDOUak9VNCEtOh voc3VkvkdhqUoSFiGW5vhTI59ZnMbpSFeLu6tLjjvuspUQs8l3oaGxmV8XOf+WzDE28TKgKy/Hx Eewgd+Nib4yDHD4V2mlSydhk1Rwvs2CAI8F7JKcE99vNhFzGsXgR1NV9s0b1TrB1cO7WZksJizD v+Sn0Vbby1O31CdqbZtFZtIMqLyKVMj+vHdkchnh/XK3HNojEM9hnKfSWZuJYFKCI18xv1ZfGln 7iA/3GCJQi2wO0amnKTVJ1EO2Q3o/PjIlPVcWu9UawxEoqMiYXovSAMxy3E1dvsX2cxHLnJffl2 fUXYSzNFQt/WKk60WKg== X-Authority-Analysis: v=2.4 cv=H6LrBeYi c=1 sm=1 tr=0 ts=6a353e21 cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=JHF-0WCA65l3F0HK4SEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE5MDEyMiBTYWx0ZWRfX+84WDqZa5wK+ QkxwW/eCuJVBOgWldcgvcyVIwkgCDqdODKeQkfTWa2NzDsYB93BexwDFW131wR5iTf38+lO7MIe XEjPOyDaT/wHTQczfxNpsKpcob2WkkU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-19_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606190122 On 6/19/26 2:59 PM, Vladimir Zapolskiy wrote: > On 6/19/26 15:35, Konrad Dybcio wrote: >> On 6/11/26 7:29 AM, Pengyu Luo wrote: >>> On Tue, Jun 9, 2026 at 8:17 PM Konrad Dybcio >>> wrote: >>>> >>>> On 6/7/26 6:04 PM, Pengyu Luo wrote: >>>>> Define pinctrl definitions to enable camera master clocks on sc8280xp. >>>>> >>>>> Suggested-by: Vladimir Zapolskiy >>>>> Signed-off-by: Pengyu Luo >>>>> --- >>>>>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 56 ++++++++++++++++++++++++++ >>>>>   1 file changed, 56 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>>>> index a2bd6b10e475..0dbcd3069a3b 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>>>> @@ -5484,6 +5484,62 @@ tlmm: pinctrl@f100000 { >>>>>                        gpio-ranges = <&tlmm 0 0 230>; >>>>>                        wakeup-parent = <&pdc>; >>>>> >>>>> +                     cam_mclk0_default: cam-mclk0-default-state { >>>>> +                             pins = "gpio119"; >>>>> +                             function = "cam_mclk"; >>>>> +                             drive-strength = <6>; >>>> >>>> Other platforms set this to 2 by default. >>>> >>>> What's the value set on Windows when the camera is in use? >>>> >>> >>> It is 6mA. >>> >>> Let us get ctl_reg first on Windows >>> >>> lkd> !dd f111000 L8 >>> # f111000 00000284 00000002 000000e2 00000000 >>> # f111010 00000001 00000801 00000000 00000000 >>> >>> ctl_reg => 0x284 >>> >>> in msm_gpio_dbg_show_one() >>> ... >>> drive = (ctl_reg >> g->drv_bit) & 7; // (0x284 >> 6) & 7 == 2 >>> ... >>> seq_printf(s, " %dmA", msm_regval_to_drive(drive)); // (drive + 1) * 2 == 6; >>> ... >>> >>> x13s should be the same as gaokun3 in this part. >> >> I confirmed as much and I'm willing to believe this is a default for >> all 8280 devices >> >> Reviewed-by: Konrad Dybcio >> >> for the second patch, please mention in the commit message that the value >> will now match windows and please add a fixes tag >> > > I believe the second change cannot be tagged as Fixes in sense that it > strictly depends on a not going to be backported non-fix commit, and thus > backporting of just 2/2 change as is will break the matter. Reordering of > the commits placing the fix commit as the first one should be fine though. The Fixes tag makes the patch eligible for backporting through AUTOSEL but is itself not the same as "please backport" Konrad