mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Etienne Carriere <etienne.carriere@foss.st.com>,
	<linux-kernel@vger.kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Kevin Hilman <khilman@baylibre.com>, <soc@kernel.org>,
	<arm@kernel.org>
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Add SCMI reset support
Date: Tue, 21 Nov 2023 10:19:08 +0100	[thread overview]
Message-ID: <16304f9a-fbbb-497f-917a-c2e2b8d67d9e@foss.st.com> (raw)
In-Reply-To: <20231103085400.2924282-1-etienne.carriere@foss.st.com>

Hi Etienne

On 11/3/23 09:54, Etienne Carriere wrote:
> SCMI reset controllers are used in the ARMv7 STMicroelectronics stm32mp
> boards:
> - for STM32MP13: stm32mp135f-dk
> - for STM32MP15 boards with SCMI variant, introduced by commit 5b7e58313a77
>    ("ARM: dts: stm32: Add SCMI version of STM32 boards (DK1/DK2/ED1/EV1)")
>    * stm32mp157c-ev1-scmi
>    * stm32mp157c-ed1-scmi
>    * stm32mp157c-dk2-scmi
>    * stm32mp157a-dk1-scmi
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
> ---
>   arch/arm/configs/multi_v7_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 23fc49f23d25..01b3797f9317 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -1189,6 +1189,7 @@ CONFIG_PWM_TEGRA=y
>   CONFIG_PWM_VT8500=y
>   CONFIG_KEYSTONE_IRQ=y
>   CONFIG_RESET_MCHP_SPARX5=y
> +CONFIG_RESET_SCMI=y
>   CONFIG_PHY_SUN4I_USB=y
>   CONFIG_PHY_SUN9I_USB=y
>   CONFIG_PHY_BRCM_USB=m

Just one question before to apply this patch. CONFIG_RESET_SCMI is set 
by the following dependency in drivers/reset/Kconfig:

RESET_CONTROLLER [=y] && (ARM_SCMI_PROTOCOL [=y] || COMPILE_TEST [=n])

CONFIG_ARM_SCMI is already set in multi_v7_defconfig.
CONFIG_RESET_CONTROLLER seems to be set in each platform Kconfig.

So not sure we need to force CONFIG_RESET_SCMI in the multi_v7_defconfig.

Regards
Alex

  reply	other threads:[~2023-11-21  9:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-03  8:54 Etienne Carriere
2023-11-21  9:19 ` Alexandre TORGUE [this message]
2023-11-21 15:05   ` Etienne CARRIERE - foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16304f9a-fbbb-497f-917a-c2e2b8d67d9e@foss.st.com \
    --to=alexandre.torgue@foss.st.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=etienne.carriere@foss.st.com \
    --cc=khilman@baylibre.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®