From: David Mosberger <davidm@napali.hpl.hp.com>
To: Jack Steiner <steiner@sgi.com>
Cc: akpm@osdl.org, davidm@hpl.hp.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Inefficient TLB flushing
Date: Wed, 12 Nov 2003 12:49:53 -0800 [thread overview]
Message-ID: <16306.40177.200706.688936@napali.hpl.hp.com> (raw)
In-Reply-To: <20031112200119.GA22429@sgi.com>
>>>>> On Wed, 12 Nov 2003 14:01:19 -0600, Jack Steiner <steiner@sgi.com> said:
Jack> Does this analysis look correct??
Yup.
Jack> Here is the patch that I am currently testing:
Jack> --- /usr/tmp/TmpDir.19957-0/linux/mm/memory.c_1.79 Wed Nov 12 13:56:25 2003
Jack> +++ linux/mm/memory.c Wed Nov 12 12:57:25 2003
Jack> @@ -574,9 +574,10 @@
Jack> if ((long)zap_bytes > 0)
Jack> continue;
Jack> if (need_resched()) {
Jack> + int fullmm = (*tlbp)->fullmm;
Jack> tlb_finish_mmu(*tlbp, tlb_start, start);
Jack> cond_resched_lock(&mm->page_table_lock);
Jack> - *tlbp = tlb_gather_mmu(mm, 0);
Jack> + *tlbp = tlb_gather_mmu(mm, fullmm);
Jack> tlb_start_valid = 0;
Jack> }
Jack> zap_bytes = ZAP_BLOCK_SIZE;
I think the patch will work fine, but it's not very clean, because it
bypasses the TLB-flush API and directly accesses
implementation-specific internals. Perhaps it would be better to pass
a "fullmm" flag to unmap_vmas(). Andrew?
--david
next prev parent reply other threads:[~2003-11-12 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-12 20:01 Jack Steiner
2003-11-12 20:49 ` David Mosberger [this message]
2003-11-12 21:22 ` Andrew Morton
2003-11-13 3:18 ` Jack Steiner
2003-11-13 3:31 ` Andrew Morton
2003-11-13 3:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16306.40177.200706.688936@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=akpm@osdl.org \
--cc=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®