From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 868F43845A6 for ; Wed, 17 Jun 2026 08:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781683807; cv=none; b=onTxsJoj3DfpgsjZfK+8oQAHGQBJ6zILE5OecYDVxutu5lPwJFIj0x638G7yEnhjh0YgTd4dFGa6Ck3kLgpQ+FLODRK+b/4dJmhiUTbTvLTOJ34gCB/9OLof/bmB1BKHpwoYKwxi8f13MaJ1FOsCkLW8CkX3Ix683iotKUKrS34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781683807; c=relaxed/simple; bh=xwvy2ZcXRdQVNsdvURg5djpvEAjHUGBfx+ulYsnHkXw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B12uIMifI2+ESv2AnBuZ7/yzjQZ8jaEgHI76jdj0Z+MsICDRwkZcCmGISY+AA58YhewCy4g5mt7dEgrpMnv2NzPgzPZI6eeaC0pspCcQQCEijxGiqmMpSlLw5j6dxnwvj6mFGDpRJSWRToulIjW2CSI2WQP+WkLC6T8iV1MwdaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GCoTvWIz; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GCoTvWIz" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-45eea68dd6fso2936611f8f.2 for ; Wed, 17 Jun 2026 01:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781683804; x=1782288604; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=wJVNCdcKD4gEI2MuivW/VCnurJJvnKmFjFb94f74ebs=; b=GCoTvWIzzLU5hSaEuQ6lsrqcRPFAfOWfFU/o2l9cM4bsZ+o09Vcm8nfgK7fYlJDhvh pYjmXZgU+71or1S68XsgtCjFsngKByfdU83dGGYCZZTBqTrQzoB0fZ1zvhPfURBsYqsK Wk1djoG3eaBSTvtxFEpTMKjjRrXR9Ckl7ZiTq06AN8nznmxwNAQo9LcUyZQjNZ9PYXJd 2Da/qfuDlMC7tpbyjWW/XK1kfSkCTsgsQ3+erzstJRX2I3nrz1ofdTXSMp/jstdosZfR LwYsGZvdO4A12fu+An3r6lNFm7WPf25EbS0YqRVnvuyRSjce0JF8g02IPGb8e+kvCN3x hPTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781683804; x=1782288604; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wJVNCdcKD4gEI2MuivW/VCnurJJvnKmFjFb94f74ebs=; b=GiNymBxxe0Yz4LJ1//3a9b+j3BxKMOPzmnq1fsdVNf6X5bAwUHfydhd7XGVQmf4vDQ CUPRuGn6fSi5EwmzX+b9A7ic72WCff+nzbMNpoeaEqMW3n2bCjY0BpYruTffp3M4C7/z WHdOjJNtD5KjG/Dtzt6jBpB6B41gwEK4Bqt3ZnSTQHsT1H6w75qiMd+mQcijXW1vpS/o Ri4oD1EAVixhCb/pnFSrGzcK6Ll+j02mnIYg8GWB8prlC9vhjFpN/iVisy6D9D3XrU05 w2tX7rR5o0P78D/RRfoLocROXLRTKVpRpKlA8yinQMyVb1J47A8eGD/FSTVC3WzP1MFc 9aDQ== X-Forwarded-Encrypted: i=1; AFNElJ9faJjPChkxXUmUtVOG+YU/y9Hej+vtwyzEJ0rbruWFGba/FCgUQGdqOD2HirdfopMaYEpEjv+04YT2eLY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywti276yvX8D+AUGc5uR8VzZa4YNWWJR9b5s/62EfM8pdkyXrSW 6LzLnbTLjzcbTpJEZ3qUzMMim+sGhqqg05nEzo4QeW2dfbD2Z8MupaBjXjE8gMbTQdc= X-Gm-Gg: AfdE7clqwTG7+SJoXQFZS7UzneS+X8HQcsUlGiVdRWa1poZ/v9/yI/ahiva1PX3VJRi m8XszdrD2zhls5+4VvFxYYoFd1XJwvdNGQIi4kunSriH3FaF9aqn1MejxQjhsYIrvhnP7OK97tE ww78Po0SbyWnhbMGn92iUZo9QeVwQL1qDS0MPxfTfeHU037rNQyb+BKeYutXxHK8Npx/fag62YX wb++7o7zwMUb557pmdnKxRNFBAGZpEWer+yHf/dNvcE2D63Uo4k/6aRXHDWfyuYTevpq0leJER7 AEVM/9mh4y8DBW+puiCcqbQ5zQ6z1WXYB5Ttm5mikT+M1VkVH6tPyeoTTG38IoHvHljMTZFAlua DqJXuEAEjE14+bnHTE2MnAxSsdM4PwwOLdc5mcnLN+M9AOp565V3uakl2aJFKwioyTFbez1gjz8 oK2vDenJum64u9E+en6XNriQ== X-Received: by 2002:a5d:588d:0:b0:45e:d3aa:e45f with SMTP id ffacd0b85a97d-462416a2b3bmr4312960f8f.28.1781683803754; Wed, 17 Jun 2026 01:10:03 -0700 (PDT) Received: from [10.12.4.106] ([212.133.41.97]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26f1cdsm53999576f8f.11.2026.06.17.01.10.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 01:10:02 -0700 (PDT) Message-ID: <16314a15-2891-475d-b6c8-591af87f1330@linaro.org> Date: Wed, 17 Jun 2026 10:10:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH v2 0/5] clk: implement sync_state support To: Brian Masney , Saravana Kannan , Abel Vesa , Maxime Ripard , Michael Turquette , Stephen Boyd , Russell King , Bjorn Andersson , Hans de Goede , Konrad Dybcio , Dmitry Baryshkov Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jens Glathe References: <20260616-clk-sync-state-v2-0-15f82c64d95c@redhat.com> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260616-clk-sync-state-v2-0-15f82c64d95c@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/16/26 23:09, Brian Masney wrote: > The existing support for disabling unused clks runs in the late initcall > stage, and it has been known for a long time that this is broken since > it runs too early in the boot up process. It doesn't work for kernel > modules, and it also doesn't work if all of the consumers haven't fully > probed yet. Folks have long recommended to boot certain platforms with > clk_ignore_unused to work around issues with disabling unused clks. > > This series: > - Adds a generic clk_sync_state() callback that's initially empty. > - Adds a generic qcom_cc_sync_state() for qcom SoCs that need to > interact with the Interconnect framework. > - Converts the 7 qcom drivers from using icc_sync_state() to > qcom_cc_sync_state(). > - Implement the framework-level sync state via clk_sync_state(). > > This approach maintains bisectability. > > Changes in v2: > - Split out clk-cbf-8996.c into it's own patch, and don't call > qcom_cc_sync_state(). > - Clarify comment above call to dev_set_drv_sync_state() about > the -EBUSY. > - Added Tested-by from Jens > - Link to v1: https://lore.kernel.org/r/20260603-clk-sync-state-v1-0-457120eed200@redhat.com > > Signed-off-by: Brian Masney > --- > Brian Masney (5): > clk: introduce stub clk_sync_state() > clk: qcom: common: introduce qcom_cc_sync_state() > clk: qcom: convert from icc_sync_state() to qcom_cc_sync_state() > clk: qcom: cbf-8996: add clk_sync_state() call > clk: implement sync_state support > > drivers/clk/clk.c | 76 +++++++++++++++++++++++++++++++++------- > drivers/clk/qcom/apss-ipq5424.c | 3 +- > drivers/clk/qcom/clk-cbf-8996.c | 8 +++-- > drivers/clk/qcom/common.c | 9 +++++ > drivers/clk/qcom/common.h | 1 + > drivers/clk/qcom/gcc-ipq5332.c | 3 +- > drivers/clk/qcom/gcc-ipq5424.c | 3 +- > drivers/clk/qcom/gcc-ipq9574.c | 3 +- > drivers/clk/qcom/nsscc-ipq5424.c | 3 +- > drivers/clk/qcom/nsscc-ipq9574.c | 3 +- > include/linux/clk.h | 14 ++++++++ > 11 files changed, 100 insertions(+), 26 deletions(-) > --- > base-commit: 08484c504b55a98bd100527fbe10a3caf55ff3ff > change-id: 20260602-clk-sync-state-c0539c5530f4 > > Best regards, Just ran this patchset on the Amlogic boards (AML-S905X-CC, AML-S805X-CC, BPI-M2S, BPI-M5) in my CI lab, and it behaved correctly. Tested-by: Neil Armstrong # on AML-S905X-CC, AML-S805X-CC, BPI-M2S, BPI-M5 Thanks, Neil