From: "tip-bot2 for Tim Gardner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Tim Gardner <tim.gardner@canonical.com>,
Borislav Petkov <bp@suse.de>,
Giovanni Gherdovich <ggherdovich@suse.cz>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/cleanups] x86/smp: Remove unnecessary assignment to local var freq_scale
Date: Fri, 17 Sep 2021 19:27:19 -0000 [thread overview]
Message-ID: <163190683957.25758.3367474272186551096.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210910184405.24422-1-tim.gardner@canonical.com>
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 85784470efa2d5733e86679ba05d310ece81b20f
Gitweb: https://git.kernel.org/tip/85784470efa2d5733e86679ba05d310ece81b20f
Author: Tim Gardner <tim.gardner@canonical.com>
AuthorDate: Fri, 10 Sep 2021 12:44:05 -06:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Fri, 17 Sep 2021 21:20:34 +02:00
x86/smp: Remove unnecessary assignment to local var freq_scale
Coverity warns of an unused value in arch_scale_freq_tick():
CID 100778 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value 1024ULL to freq_scale here, but that stored
value is overwritten before it can be used.
It was introduced by commit:
e2b0d619b400a ("x86, sched: check for counters overflow in frequency invariant accounting")
Remove the variable initializer.
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Giovanni Gherdovich <ggherdovich@suse.cz>
Link: https://lkml.kernel.org/r/20210910184405.24422-1-tim.gardner@canonical.com
---
arch/x86/kernel/smpboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 85f6e24..c453b82 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -2166,7 +2166,7 @@ DEFINE_PER_CPU(unsigned long, arch_freq_scale) = SCHED_CAPACITY_SCALE;
void arch_scale_freq_tick(void)
{
- u64 freq_scale = SCHED_CAPACITY_SCALE;
+ u64 freq_scale;
u64 aperf, mperf;
u64 acnt, mcnt;
prev parent reply other threads:[~2021-09-17 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 18:44 [PATCH] x86/smp: Unused value freq_scale Tim Gardner
2021-09-15 7:12 ` Giovanni Gherdovich
2021-09-17 19:27 ` tip-bot2 for Tim Gardner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163190683957.25758.3367474272186551096.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=bp@suse.de \
--cc=ggherdovich@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tim.gardner@canonical.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®