From: patchwork-bot+netdevbpf@kernel.org
To: Colin Foster <colin.foster@in-advantage.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
vladimir.oltean@nxp.com, claudiu.manoil@nxp.com,
alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH v3 net 0/2] ocelot phylink fixes
Date: Sun, 19 Sep 2021 12:10:08 +0000 [thread overview]
Message-ID: <163205340828.3254.3027678837058017593.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210917153905.1173010-1-colin.foster@in-advantage.com>
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Fri, 17 Sep 2021 08:39:03 -0700 you wrote:
> When the ocelot driver was migrated to phylink, e6e12df625f2 ("net:
> mscc: ocelot: convert to phylink") there were two additional writes to
> registers that became stale. One write was to DEV_CLOCK_CFG and one was
> to ANA_PFC_PCF_CFG.
>
> Both of these writes referenced the variable "speed" which originally
> was set to OCELOT_SPEED_{10,100,1000,2500}. These macros expand to
> values of 3, 2, 1, or 0, respectively. After the update, the variable
> speed is set to SPEED_{10,100,1000,2500} which expand to 10, 100, 1000,
> and 2500. So invalid values were getting written to the two registers,
> which would lead to either a lack of functionality or undefined
> funcationality.
>
> [...]
Here is the summary with links:
- [v3,net,1/2] net: mscc: ocelot: remove buggy and useless write to ANA_PFC_PFC_CFG
https://git.kernel.org/netdev/net/c/163957c43d96
- [v3,net,2/2] net: mscc: ocelot: remove buggy duplicate write to DEV_CLOCK_CFG
https://git.kernel.org/netdev/net/c/ba68e9941984
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-09-19 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 15:39 Colin Foster
2021-09-17 15:39 ` [PATCH v3 net 1/2] net: mscc: ocelot: remove buggy and useless write to ANA_PFC_PFC_CFG Colin Foster
2021-09-17 15:39 ` [PATCH v3 net 2/2] net: mscc: ocelot: remove buggy duplicate write to DEV_CLOCK_CFG Colin Foster
2021-09-19 12:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163205340828.3254.3027678837058017593.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome