From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B53C433F5 for ; Wed, 22 Sep 2021 17:19:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 423D860FE6 for ; Wed, 22 Sep 2021 17:19:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236788AbhIVRUo (ORCPT ); Wed, 22 Sep 2021 13:20:44 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:56872 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236701AbhIVRUm (ORCPT ); Wed, 22 Sep 2021 13:20:42 -0400 Date: Wed, 22 Sep 2021 17:19:10 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1632331151; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M8sGgJ+s5czYLK9wLGjOAGzyMWGNI8XL8H5NwfPZl4Y=; b=oLntkA3bfcLUyZkS5avVqJ0P5eEo3atbxihEijSKpMZSsv8ejCT6gI3c0PRgqvDjgnDLwx uDhPlykP9mh3JqEvSr8SboR5drq3MN6YFdX/gxOYbCbP1CBVPClEt6OB6ApGkhkD5YWJiN csSPKlAq/uRSj7sp3Ql29IfqDvZBb9gJS9Qf7JRtHpmZEMntjgPTToI+rAoRboqhoXbKni GvZhVFzdMbqEiUxzlqV8HVxhIpr6jb+aaqn/YWvU+JtYtwUe03bBtJsYyZ+TwK2ZtuTlwS cRJ9SKeaYwimwtQezbkYUzds47jF/i4Acew7zl78+nFj4EujBJKs6nzTfCwGtw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1632331151; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M8sGgJ+s5czYLK9wLGjOAGzyMWGNI8XL8H5NwfPZl4Y=; b=zV2xSHKcbx5EmDdzSq+TDWdWhlBR14n5sHrDI2+EpcOLEd+TwWqujEidGplsOiRRwAR+v3 ijnccO4HxLe+0WDg== From: "tip-bot2 for Randy Dunlap" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/misc] x86/Kconfig: Fix an unused variable error in dell-smm-hwmon Cc: Arnd Bergmann , Randy Dunlap , Borislav Petkov , Guenter Roeck , pali@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20210910071921.16777-1-rdunlap@infradead.org> References: <20210910071921.16777-1-rdunlap@infradead.org> MIME-Version: 1.0 Message-ID: <163233115058.25758.6853656807950257652.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/misc branch of tip: Commit-ID: 64c76a84337a5678009155fafe98c5cd8ec673f0 Gitweb: https://git.kernel.org/tip/64c76a84337a5678009155fafe98c5cd8ec= 673f0 Author: Randy Dunlap AuthorDate: Fri, 10 Sep 2021 00:19:21 -07:00 Committer: Borislav Petkov CommitterDate: Wed, 22 Sep 2021 19:09:56 +02:00 x86/Kconfig: Fix an unused variable error in dell-smm-hwmon When CONFIG_PROC_FS is not set, there is a build warning (turned into an error): ../drivers/hwmon/dell-smm-hwmon.c: In function 'i8k_init_procfs': ../drivers/hwmon/dell-smm-hwmon.c:624:24: error: unused variable 'data' [-W= error=3Dunused-variable] struct dell_smm_data *data =3D dev_get_drvdata(dev); Make I8K depend on PROC_FS and HWMON (instead of selecting HWMON -- it is strongly preferred to not select entire subsystems). Build tested in all possible combinations of SENSORS_DELL_SMM, I8K, and PROC_FS. Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /= proc/i8k") Reported-by: Arnd Bergmann Signed-off-by: Randy Dunlap Signed-off-by: Borislav Petkov Reviewed-by: Arnd Bergmann Acked-by: Guenter Roeck Acked-by: Pali Roh=C3=A1r Link: https://lkml.kernel.org/r/20210910071921.16777-1-rdunlap@infradead.org --- arch/x86/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index dad7f85..e5ba8af 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1256,7 +1256,8 @@ config TOSHIBA =20 config I8K tristate "Dell i8k legacy laptop support" - select HWMON + depends on HWMON + depends on PROC_FS select SENSORS_DELL_SMM help This option enables legacy /proc/i8k userspace interface in hwmon