From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2AFBC433F5 for ; Thu, 23 Sep 2021 09:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FD6961279 for ; Thu, 23 Sep 2021 09:00:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240081AbhIWJCU (ORCPT ); Thu, 23 Sep 2021 05:02:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240005AbhIWJCT (ORCPT ); Thu, 23 Sep 2021 05:02:19 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F6CEC061574; Thu, 23 Sep 2021 02:00:48 -0700 (PDT) Date: Thu, 23 Sep 2021 09:00:44 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1632387646; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KqDgHp7pC65TYmLcgMpRezFaGOBqgpP9GGW8svCrzOQ=; b=RE0wdvIxHLEuMS6ValV7lR+a5ifepDM7F0Jhkp7nwsloIsaOkeQakhg4Fw5wWuRGeN/bzF sKyvfAJIqnGHN0+HdSbtlauQyPbV6UGqCgoawPgDtK/r4D8SH81lwN7FnvNSho2bld7v1O xWglhrgWIYn2CyaTUlzD3/rYVAdMVtREbtsgX5uWv8l7bECz5iewBIt19ipSPnzV41fYcK 0pGin1dfmb8I5VjZF+1ahvjXy+yT1G21oMRH6iNNr39hJ4Tjv2keZb60PQ0aUlt0gMs3L1 +BNBKRumaQWE2Qt0X4Zh2kJbsgKcXkOU8l0sH2IQOBgDjeqUpJUM0kWnVBcm6A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1632387646; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KqDgHp7pC65TYmLcgMpRezFaGOBqgpP9GGW8svCrzOQ=; b=QKKMIsDaXJT7iD2Je3oCYj9zWYmWMfcZpACIdlyM0w/pTgVX8BWwxm6+5F2fpG4HTiQrOe Xs+qLX5jtXXjjsDw== From: "tip-bot2 for Anders Roxell" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/fpu] x86/fpu/signal: Fix missed conversion to correct boolean retval in save_xstate_epilog() Cc: Remi Duraffort , Anders Roxell , Borislav Petkov , Nick Desaulniers , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20210922200901.1823741-1-anders.roxell@linaro.org> References: <20210922200901.1823741-1-anders.roxell@linaro.org> MIME-Version: 1.0 Message-ID: <163238764483.25758.11716568924329080028.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/fpu branch of tip: Commit-ID: 724fc0248d450224b19ef5b5ee41e392348f6704 Gitweb: https://git.kernel.org/tip/724fc0248d450224b19ef5b5ee41e392348f6704 Author: Anders Roxell AuthorDate: Wed, 22 Sep 2021 22:09:01 +02:00 Committer: Borislav Petkov CommitterDate: Thu, 23 Sep 2021 10:52:20 +02:00 x86/fpu/signal: Fix missed conversion to correct boolean retval in save_xstate_epilog() Fix the missing return code polarity in save_xstate_epilog(). [ bp: Massage, use the right commit in the Fixes: tag ] Fixes: 2af07f3a6e9f ("x86/fpu/signal: Change return type of copy_fpregs_to_sigframe() helpers to boolean") Reported-by: Remi Duraffort Signed-off-by: Anders Roxell Signed-off-by: Borislav Petkov Tested-by: Nick Desaulniers Link: https://github.com/ClangBuiltLinux/linux/issues/1461 Link: https://lkml.kernel.org/r/20210922200901.1823741-1-anders.roxell@linaro.org --- arch/x86/kernel/fpu/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/fpu/signal.c b/arch/x86/kernel/fpu/signal.c index 68f03da..39c7bae 100644 --- a/arch/x86/kernel/fpu/signal.c +++ b/arch/x86/kernel/fpu/signal.c @@ -106,7 +106,7 @@ static inline bool save_xstate_epilog(void __user *buf, int ia32_frame) err = __copy_to_user(&x->i387.sw_reserved, sw_bytes, sizeof(*sw_bytes)); if (!use_xsave()) - return err; + return !err; err |= __put_user(FP_XSTATE_MAGIC2, (__u32 __user *)(buf + fpu_user_xstate_size));