mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Borislav Petkov <bp@suse.de>
Cc: Loc Ho <lho@apm.com>,
	msalter@redhat.com, rafael@kernel.org, tbaicar@codeaurora.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, patches@apm.com, "Luck,
	Tony" <tony.luck@intel.com>
Subject: Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ
Date: Wed, 26 Jul 2017 20:57:03 +0200	[thread overview]
Message-ID: <1632667.Vgem7HtdXu@aspire.rjw.lan> (raw)
In-Reply-To: <1893763.BLgt1zgLk5@aspire.rjw.lan>

On Sunday, July 23, 2017 12:01:10 AM Rafael J. Wysocki wrote:
> On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> > On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > > X-Gene platforms describe multiple GHES error sources with the same hardware
> > > error notification type (external interrupt) and interrupt number.
> > > Change the GHES interrupt request to support sharing the same IRQ.
> > > 
> > > Co-authored-by: Tuan Phan <tphan@apm.com>
> > > Signed-off-by: Loc Ho <lho@apm.com>
> > > ---
> > >  drivers/acpi/apei/ghes.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > > index d661d45..eed09fc 100644
> > > --- a/drivers/acpi/apei/ghes.c
> > > +++ b/drivers/acpi/apei/ghes.c
> > > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
> > >  			       generic->header.source_id);
> > >  			goto err_edac_unreg;
> > >  		}
> > > -		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > > +		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > > +				 "GHES IRQ", ghes);
> > >  		if (rc) {
> > >  			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
> > >  			       generic->header.source_id);
> > 
> > Acked-by: Borislav Petkov <bp@suse.de>
> 
> OK
> 
> Should I apply this or will Tony do that?

So am I suppsed to drop this?

  reply	other threads:[~2017-07-26 19:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 18:24 [PATCH v6 0/1] acpi: apei: Bug fix to enable APEI support for ARMv8 Loc Ho
2017-07-21 18:24 ` [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ Loc Ho
2017-07-22  5:59   ` Borislav Petkov
2017-07-22 22:01     ` Rafael J. Wysocki
2017-07-26 18:57       ` Rafael J. Wysocki [this message]
2017-07-27  5:58         ` Borislav Petkov
2017-07-27 14:34           ` Rafael J. Wysocki
2017-07-27 14:49             ` Borislav Petkov
2017-07-27 15:09               ` Rafael J. Wysocki
2017-07-27 16:49                 ` Luck, Tony
2017-07-28  7:35                   ` [PATCH] MAINTAINERS: Add Tony and Boris as ACPI/APEI reviewers Borislav Petkov
2017-07-28 17:02                     ` Luck, Tony
2017-08-01 23:14                       ` Rafael J. Wysocki
2017-08-01 23:13     ` [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1632667.Vgem7HtdXu@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=bp@suse.de \
    --cc=lho@apm.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msalter@redhat.com \
    --cc=patches@apm.com \
    --cc=rafael@kernel.org \
    --cc=tbaicar@codeaurora.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®