From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63783C433F5 for ; Tue, 5 Oct 2021 12:23:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 471FA61425 for ; Tue, 5 Oct 2021 12:23:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234711AbhJEMZZ (ORCPT ); Tue, 5 Oct 2021 08:25:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:44028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234409AbhJEMZX (ORCPT ); Tue, 5 Oct 2021 08:25:23 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 80AD561186; Tue, 5 Oct 2021 12:23:33 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mXjTn-00EsEH-Ih; Tue, 05 Oct 2021 13:23:31 +0100 From: Marc Zyngier To: Alexandru Elisei , Quentin Perret , Will Deacon , Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Steven Price , Suzuki K Poulose Cc: kernel-team@android.com Subject: Re: [PATCH] KVM: arm64: Release mmap_lock when using VM_SHARED with MTE Date: Tue, 5 Oct 2021 13:23:28 +0100 Message-Id: <163343660135.3849383.15321540060917928025.b4-ty@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211005122031.809857-1-qperret@google.com> References: <20211005122031.809857-1-qperret@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, qperret@google.com, will@kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, james.morse@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, steven.price@arm.com, suzuki.poulose@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Oct 2021 13:20:31 +0100, Quentin Perret wrote: > VM_SHARED mappings are currently forbidden in a memslot with MTE to > prevent two VMs racing to sanitise the same page. However, this check > is performed while holding current->mm's mmap_lock, but fails to release > it. Fix this by releasing the lock when needed. Applied to fixes, thanks! [1/1] KVM: arm64: Release mmap_lock when using VM_SHARED with MTE commit: 6e6a8ef088e1222cb1250942f51ad9c1ab219ab2 Cheers, M. -- Without deviation from the norm, progress is not possible.