From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053AbdCNNat (ORCPT ); Tue, 14 Mar 2017 09:30:49 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:60082 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbdCNNap (ORCPT ); Tue, 14 Mar 2017 09:30:45 -0400 X-AuditID: b6c32a39-f799f6d000001a36-dc-58c7f07ce2c0 From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Wim Van Sebroeck , Guenter Roeck , Rob Herring , Kukjin Kim , Javier Martinez Canillas , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards Date: Tue, 14 Mar 2017 14:30:29 +0100 Message-id: <1633762.1QWnRjdako@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsWy7bCmvm7Nh+MRBn1zJSzmHznHavHm7Rom i/7Hr5ktzp/fwG6x6fE1VovLu+awWcw4v4/J4sa6fewWTxaeYbJo3XuE3eLWjBesDtwe1zaL eWxa1cnmsXlJvceW/rvsHju/N7B7fN4kF8AWxWWTkpqTWZZapG+XwJUxseM7U8FWropNi88y NjAu5ehi5OCQEDCROHYuv4uRE8gUk7hwbz1bFyMXh5DADkaJzct3sYIkhATamST+TGOGKDKR uLz9MTNE0RxGiR8tK6Ccr4wSn25dA+tgE7CSmNi+ihHEFhHQlLj+9zsrSBGzwHMmiR3vXjOC rBYWCJNY+ycDpIZFQFViyfXZYBt4geo/7DnNBmKLCnhJbNnXzgRicwoES2w6fAKqRlDix+R7 LCA2s4C8xL79U1khbB2Js8fWMYLskhA4xS5x4MwkFog3ZSU2HYD6wEXi3cM/TBC2sMSr41vY IWxpiVX/bkHFpzNKbP8tATFnM6PEqt0ToIqsJQ4fvwi1jE/i3dceVoj5vBIdbUIQJR4Su87f hSp3lJh36xQ0SN8zSkzduoJxAqP8LCQ/zELywywkPyxgZF7FKJZaUJybnlpsWGCqV5yYW1ya l66XnJ+7iRGcgLQsdzAeO+dziFGAg1GJh/fGvGMRQqyJZcWVuYcYJTiYlUR4H784HiHEm5JY WZValB9fVJqTWnyIUZqDRUmcl9VgYoSQQHpiSWp2ampBahFMlomDU6qBMfGY6O/LroH7T258 /MT2Fh+Hl2OX3CrZ1VXpP00UYtv99qUVVvw9r8A6Xy90Y2BP6b6MfM/9+XrtzEavma6sMmUQ 83gd4JN+b2GSmuS8RZ++zNNt99jvk72+yWEC7z69mYoJLxe4HIsy/vHyfj5fqIANn9pyZrtf u9YoVMjsmltzckbMjMi1SizFGYmGWsxFxYkAJgxe7DwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jQd3qD8cjDBY/F7GYf+Qcq8Wbt2uY LPofv2a2OH9+A7vFpsfXWC0u75rDZjHj/D4mixvr9rFbPFl4hsmide8RdotbM16wOnB7XNss 5rFpVSebx+Yl9R5b+u+ye+z83sDu8XmTXABblJtNRmpiSmqRQmpecn5KZl66rVJoiJuuhZJC XmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTtEtwyJnZ8ZyrYylWxafFZxgbGpRxdjJwc EgImEpe3P2aGsMUkLtxbz9bFyMUhJDCLUWL7hHZWCOcro8S77qNsIFVsAlYSE9tXMYLYIgKa Etf/fgcrYhZ4ySRxatsvsCJhgTCJXd3bWEFsFgFViSXXZ4Ot4AVq+LDnNFiNqICXxJZ97Uwg NqdAsETvlymMENtmM0oc/fCTBaJBUOLH5HtgNrOAvMS+/VNZIWwtifU7jzNNYAQ6FKFsFpKy WUjKFjAyr2KUSC1ILihOSs81zEst1ytOzC0uzUvXS87P3cQIjstnUjsYD+5yP8QowMGoxMN7 Y96xCCHWxLLiytxDjBIczEoivI9fHI8Q4k1JrKxKLcqPLyrNSS0+xGgK9OFEZinR5Hxgysgr iTc0MTcxNzawMLe0NDFSEudtnP0sXEggPbEkNTs1tSC1CKaPiYNTqoFRJPl0yVKlqz3NR0Vb c4xLpzVFF7Zbr5/rWbz6yDapxBSXknTLlEm3PY+0X54n/MrF9NKTvNdW551iCr+XPleZXjSl Oeea61Glej//hlyOKYserbY/HrShza7Y4pJfhveTH573vZ7XGARZF/RttlFK58pMZ3/79vkT 9fUuH1d23+37q6m3UVWJpTgj0VCLuag4EQAach9z4QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170314133035epcas1p47a04430402688bbb6baebad69b8e5b24 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170314133035epcas1p47a04430402688bbb6baebad69b8e5b24 X-RootMTR: 20170314133035epcas1p47a04430402688bbb6baebad69b8e5b24 References: <20170311172527.16368-1-krzk@kernel.org> <4386279.iJpUOasmTG@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, March 14, 2017 03:04:28 PM Krzysztof Kozlowski wrote: > On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote: > >> Watchdog module does not have external dependencies so it can be safely > >> enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based > >> boards. > >> > >> Signed-off-by: Krzysztof Kozlowski > > > > Please first fix the driver w.r.t. infinite interrupt in soft mode > > issue and only then enable it on more hardware. IOW this patch > > should be placed after patch #7 in the series. > > The soft-interrupt mode is not the default one so this should not > cause any issues by default but I got your point. Makes sense. The > pity is the timing. There wasn't much interest in the patchset (no > comments since 24 of Feb) so I merged it yesterday evening. Does it > brake any platform/board? OK, let it be as it as it doesn't break the default setup. However please consider the fact that posting revised patches (v2 was posted *yesterday*) for a review and then merging them the same day is not a good practice.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics