From: David Mosberger <davidm@napali.hpl.hp.com>
To: Paul Menage <menage@google.com>
Cc: "Grover, Andrew" <andrew.grover@intel.com>,
linux-kernel@vger.kernel.org, acpi-devel@lists.sourceforge.net
Subject: Re: [ACPI] ACPI global lock macros
Date: Tue, 9 Dec 2003 11:03:15 -0800 [thread overview]
Message-ID: <16342.7283.350878.950554@napali.hpl.hp.com> (raw)
In-Reply-To: <3FD61CA5.6050203@google.com>
>>>>> On Tue, 09 Dec 2003 11:04:05 -0800, Paul Menage <menage@google.com> said:
Paul> Grover, Andrew wrote:
>> BTW, i386, x86_64 and ia64 all have this macro, so these all might need
>> to be looked at.
Paul> Yes, it was the differences between the i386 and x86_64
Paul> versions that made me notice this problem. The ia64 version is
Paul> in C, so looks safer. Ideally there would be a common C
Paul> definition - the only arch-specific part should be the locked
Paul> cmpxchg, unless this lock is likely to be taken/released so
Paul> often that it's performance critical.
As far as ia64 is concerned, you could replace ia64_cmpxchg4_acq()
with cmpxchg(). That should just work. Of course, as you point out,
that wouldn't work on x86 UP because of the missing "lock" prefix.
Sounds like you'd need to add something along the lines of
device_atomic_cmpxchg() or something like that...
--david
next prev parent reply other threads:[~2003-12-09 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 18:20 Grover, Andrew
2003-12-09 19:04 ` Paul Menage
2003-12-09 19:03 ` David Mosberger [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-11 7:27 Yu, Luming
2003-12-11 17:46 ` Nate Lawson
2003-12-11 7:06 Yu, Luming
2003-12-11 8:07 ` Andi Kleen
2003-12-11 8:27 ` Paul Menage
2003-12-11 8:20 ` Paul Menage
2003-12-09 9:22 Paul Menage
2003-12-10 7:45 ` [ACPI] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16342.7283.350878.950554@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=andrew.grover@intel.com \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®