From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040AbbHOHWP (ORCPT ); Sat, 15 Aug 2015 03:22:15 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:52373 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbbHOHWN (ORCPT ); Sat, 15 Aug 2015 03:22:13 -0400 Date: Sat, 15 Aug 2015 09:21:56 +0200 (CEST) From: Stefan Wahren Reply-To: Stefan Wahren To: Srinivas Kandagatla Cc: wxt@rock-chips.com, linux-api@vger.kernel.org, Rob Herring , p.zabel@pengutronix.de, Andrew Lunn , sboyd@codeaurora.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, khilman@kernel.org, maitysanchayan@gmail.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mporter@konsulko.com, pantelis.antoniou@konsulko.com, devicetree@vger.kernel.org, Mark Brown , Greg Kroah-Hartman Message-ID: <1634428787.18822.1439623316281.JavaMail.open-xchange@oxbsltgw04.schlund.de> In-Reply-To: <1439291024-18375-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1439290931-18232-1-git-send-email-srinivas.kandagatla@linaro.org> <1439291024-18375-1-git-send-email-srinivas.kandagatla@linaro.org> Subject: Re: [PATCH RFC 3/3] nvmem: add permission flags in nvmem_config MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.2-Rev25 X-Originating-Client: com.openexchange.ox.gui.dhtml X-Provags-ID: V03:K0:lxYx4SKbCxPfEG9j81wRhknEvNmRLNQhu1ASrabgzJZn8Mlv+tG oo3IWHbppjRfiAaagRHsExMJTcZySxSX7caIfAHdAhgPhWkbys7Hh8gS/ZTHppRgCpJ/X/u R7x2MN2hOB2n1lvIa70QbbLLZdPxZ/v4WmC4k3K57390ZnHyqPUFglJ9i5k4x73j2DBX+Ap yO0iNbi7HUv4Zx7SMUs5w== X-UI-Out-Filterresults: notjunk:1;V01:K0:XhLCtbBTxnM=:caykj2bGX8iRjDF2GlpZ2M udCTe9ygAbJ9lOPZdM6WRY9Mepu2mRU/HONKwdlXzl6HUTrmSmqQ/mZKcmCZSZzyPTPEg1jy9 09mCf/SdMrrXEpoNUH4e/ZexZqhZNtflG25KayyL3rn6nJDNbn3IvZizi68DOfMsEHfp/A97h T4xw5ydw8Xb3TQ7bmg3Pxa8hALpSRCC6udyQlISWNwNNvQaOGqAxFEzIudyX+9wK4ZYk9DqUZ ujy3CcbRmhQFcS0Ow9pFDg8omhB2KFcwXrtJePLTGcENg6tkXDwyAp+cQFLANtuqDEtIJkUmk WtBvKVc43aCGfDCXvvmGNyNhKDbGBNtw+2oXOqgDmtZelrhARc00jnn9gaGX6IPDaClpzzjMt v8WchnkQBEVJJ12iKm79eQUugVLOFQLb3bF5mZXEcVYkWZyzAp/i9ID7kobYiXGsFCzUOtjju AFAJhfN/fDRtvpmWufa+hSiFQ5Xv8hby6KrMCVqDV9Maq5rX5MptDodg1QNfim59yhwWcZI58 2n8dC7DAZHCx9+FCkXQBdLuHWO20huGRxlDc4tKrGMkO4UQ2oZLs2lQ+ljFO6kBk1DP/C29CO Lr5s3BKx0PYoYNAX7I1uFE3fRSLAuGcRw0t8Aa6vYejvEsffdZR+rx7Ee+QNqcu0N+X0aSGhj 9JwvwUzrn2AQlXJ6TvpavpiAOXRCevZZSYcysvK5ki0TRLevvItWG9CD9ZuQxH4bAL4t1SNtw M2sC6nkMch516a9z Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srinivas, > Srinivas Kandagatla hat am 11. August 2015 um > 13:03 geschrieben: > > > This patch adds perm variable to nvmem_config structure which will allow > providers to specify the permissions required for the sysfs binary file. > This permission is applied on top of root-only access permissions set by > the core. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/nvmem/core.c | 1 + > include/linux/nvmem-provider.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 414ed23..7481387 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -312,6 +312,7 @@ struct nvmem_device *nvmem_register(const struct > nvmem_config *config) > config->read_only; > nvmem->bin = bin_attr_template; > nvmem->bin.attr.mode = nvmem->read_only ? : (S_IRUSR | S_IWUSR); > + nvmem->bin.attr.mode |= config->perm; > nvmem->bin.size = nvmem->size; > device_initialize(&nvmem->dev); > > diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h > index 0b68caf..de9a61f 100644 > --- a/include/linux/nvmem-provider.h > +++ b/include/linux/nvmem-provider.h > @@ -23,6 +23,7 @@ struct nvmem_config { > const struct nvmem_cell_info *cells; > int ncells; > bool read_only; > + u16 perm; /* visibility in sysfs */ how about "umode_t mode" or "umode_t sysfs_mode"? Beside that the whole series looks good to me. Thanks Stefan