From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30EA1C433FE for ; Sun, 17 Oct 2021 11:39:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1223560F57 for ; Sun, 17 Oct 2021 11:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245550AbhJQLlb (ORCPT ); Sun, 17 Oct 2021 07:41:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:58536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245539AbhJQLl3 (ORCPT ); Sun, 17 Oct 2021 07:41:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BF72160F56; Sun, 17 Oct 2021 11:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634470760; bh=ohuMuYmmuyqyemJ4Qv+2X0qk6HWlk0oTy0Gz89ptlUo=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=fv8qMW6bkN0agW2c4cNgIEbetZ3JiM7DYltNzcFsbFJvRfmprlEBrODU/Ql3DOYyu r24ViDHOEcEdUQKjXHX9T27Pz5tFz8B/S0UhnwvQW/dJdxty4XeOHaG22aNt8BU2FY ba7yPcoY3u6ElSA6/JLK3vW1JnPtrCXAHn/m+nQmoswk6SzNrJBFpkX4YFYqc/dRG8 jJ/BzR4aY9cT9aMqcuZlOdHUNJDJG0olbNfSxB2K3WjVImjJAigQdMEnXeAFTda/Vf h+CApieJzBHKu1aNpRdxo0krso6aVAw5UG8HFg+lx/MRymFZ86mWdNqFagWKiPI2Zh QCz/N1vr6jmVQ== From: Mark Brown To: Nicolas Frattaroli Cc: Liam Girdwood , Rob Herring , Philipp Zabel , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jaroslav Kysela , alsa-devel@alsa-project.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Takashi Iwai In-Reply-To: <20211016105354.116513-1-frattaroli.nicolas@gmail.com> References: <20211016105354.116513-1-frattaroli.nicolas@gmail.com> Subject: Re: (subset) [PATCH 0/4] Getting rid of the reset controller in i2s-tdm Message-Id: <163447061131.1864024.8259786717418291207.b4-ty@kernel.org> Date: Sun, 17 Oct 2021 12:36:51 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 Oct 2021 12:53:49 +0200, Nicolas Frattaroli wrote: > after some discussion with Heiko on IRC, he has admitted to me > that the rockchip,cru property, and its corresponding half a reset > controller in the driver, is weighing heavily on his mind. > > The background is that if the lrck only uses one clock for both rx > and tx direction, then according to the downstream driver, the rx > and tx resets should be asserted at roughly the same time to keep > things in sync. > > [...] Applied, thanks! [1/4] ASoC: rockchip: i2s-tdm: Strip out direct CRU use commit: d6365d0f0a03c1feb28d86dfd192972ddc647013 [2/4] ASoC: dt-bindings: rockchip: i2s-tdm: Drop rockchip,cru property commit: 4e52cb9e2c22c9d860910794c82461064baadd9f Best regards, -- Mark Brown From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F165C433EF for ; Sun, 17 Oct 2021 11:45:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16A9161054 for ; Sun, 17 Oct 2021 11:45:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245589AbhJQLr0 (ORCPT ); Sun, 17 Oct 2021 07:47:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:60630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238081AbhJQLrZ (ORCPT ); Sun, 17 Oct 2021 07:47:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 011D360FE3; Sun, 17 Oct 2021 11:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634471115; bh=ohuMuYmmuyqyemJ4Qv+2X0qk6HWlk0oTy0Gz89ptlUo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ba2+hAgqogX5pyL/+cDfcC/L2/wrEGbJ9jKoi7XLGpqxScs6BytFNYjroMCWo/BVH V+GJtRe3JCtiIzpaITvLkS+jLIvdiSb32DsLjoQ3NldEKjX1Yr1DFm8qn725IcxcSv jeT3TatImQUuV2OsfLKFo+Nm+84zySMQ/ebFVXr/9mLOLZ/9UAQQRUOge9SjHjiOSr ZzcA9VZGfmETOOswrvr4h/N1OIO26N6D8Bkr4ffpswJF7NlbOTyIBoNsIwRP9e8+IO +X1ZiW59EdhB9dS+GW6CZDTQsdmututWLb5IXDOjZttz+DPhGsDYCvPpsdTHpiDOkn aXlduszwQTqEw== From: Mark Brown To: Nicolas Frattaroli Cc: Mark Brown , Liam Girdwood , Rob Herring , Philipp Zabel , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jaroslav Kysela , alsa-devel@alsa-project.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Takashi Iwai Subject: Re: (subset) [PATCH 0/4] Getting rid of the reset controller in i2s-tdm Date: Sun, 17 Oct 2021 12:45:06 +0100 Message-ID: <163447061131.1864024.8259786717418291207.b4-ty@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211016105354.116513-1-frattaroli.nicolas@gmail.com> References: <20211016105354.116513-1-frattaroli.nicolas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20211017114506.ij4K-yKeT-8L2-CPP1oLZBjhrru7CDyG5FH8aInLkhU@z> On Sat, 16 Oct 2021 12:53:49 +0200, Nicolas Frattaroli wrote: > after some discussion with Heiko on IRC, he has admitted to me > that the rockchip,cru property, and its corresponding half a reset > controller in the driver, is weighing heavily on his mind. > > The background is that if the lrck only uses one clock for both rx > and tx direction, then according to the downstream driver, the rx > and tx resets should be asserted at roughly the same time to keep > things in sync. > > [...] Applied, thanks! [1/4] ASoC: rockchip: i2s-tdm: Strip out direct CRU use commit: d6365d0f0a03c1feb28d86dfd192972ddc647013 [2/4] ASoC: dt-bindings: rockchip: i2s-tdm: Drop rockchip,cru property commit: 4e52cb9e2c22c9d860910794c82461064baadd9f Best regards, -- Mark Brown