From: Jens Axboe <axboe@kernel.dk>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, asml.silence@gmail.com,
io-uring@vger.kernel.org
Subject: Re: [PATCH v1] fs/io_uring: Prioritise checking faster conditions first in io_write
Date: Sun, 17 Oct 2021 08:23:41 -0600 [thread overview]
Message-ID: <163448061835.101565.1242197523580881975.b4-ty@kernel.dk> (raw)
In-Reply-To: <20211017013229.4124279-1-goldstein.w.n@gmail.com>
On Sat, 16 Oct 2021 20:32:29 -0500, Noah Goldstein wrote:
> This commit reorders the conditions in a branch in io_write. The
> reorder to check 'ret2 == -EAGAIN' first as checking
> '(req->ctx->flags & IORING_SETUP_IOPOLL)' will likely be more
> expensive due to 2x memory derefences.
>
>
Applied, thanks!
[1/1] fs/io_uring: Prioritise checking faster conditions first in io_write
commit: 02a8286be94bb1fce86afa6b487717eb4ca2956e
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2021-10-17 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 1:32 Noah Goldstein
2021-10-17 14:23 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163448061835.101565.1242197523580881975.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®