From: "tip-bot2 for Woody Lin" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Woody Lin <woodylin@google.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Valentin Schneider <valentin.schneider@arm.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/urgent] sched/scs: Reset the shadow stack when idle_task_exit
Date: Tue, 19 Oct 2021 15:55:09 -0000 [thread overview]
Message-ID: <163465890918.25758.12684036916050863511.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20211012083521.973587-1-woodylin@google.com>
The following commit has been merged into the sched/urgent branch of tip:
Commit-ID: 63acd42c0d4942f74710b11c38602fb14dea7320
Gitweb: https://git.kernel.org/tip/63acd42c0d4942f74710b11c38602fb14dea7320
Author: Woody Lin <woodylin@google.com>
AuthorDate: Tue, 12 Oct 2021 16:35:21 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 19 Oct 2021 17:46:11 +02:00
sched/scs: Reset the shadow stack when idle_task_exit
Commit f1a0a376ca0c ("sched/core: Initialize the idle task with
preemption disabled") removed the init_idle() call from
idle_thread_get(). This was the sole call-path on hotplug that resets
the Shadow Call Stack (scs) Stack Pointer (sp).
Not resetting the scs-sp leads to scs overflow after enough hotplug
cycles. Therefore add an explicit scs_task_reset() to the hotplug code
to make sure the scs-sp does get reset on hotplug.
Fixes: f1a0a376ca0c ("sched/core: Initialize the idle task with preemption disabled")
Signed-off-by: Woody Lin <woodylin@google.com>
[peterz: Changelog]
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lore.kernel.org/r/20211012083521.973587-1-woodylin@google.com
---
kernel/sched/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 1bba412..f21714e 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8795,6 +8795,7 @@ void idle_task_exit(void)
finish_arch_post_lock_switch();
}
+ scs_task_reset(current);
/* finish_cpu(), as ran on the BP, will clean up the active_mm state */
}
prev parent reply other threads:[~2021-10-19 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 8:35 [PATCH] " Woody Lin
2021-10-12 9:59 ` Valentin Schneider
2021-10-12 10:35 ` Woody Lin
2021-10-12 10:57 ` Valentin Schneider
2021-10-13 1:22 ` Woody Lin
2021-10-13 13:32 ` Valentin Schneider
2021-10-15 13:02 ` Peter Zijlstra
2021-10-19 15:23 ` [tip: sched/urgent] " tip-bot2 for Woody Lin
2021-10-19 15:55 ` tip-bot2 for Woody Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163465890918.25758.12684036916050863511.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=woodylin@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®