From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1757DC433F5 for ; Wed, 3 Nov 2021 05:06:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E82BE6109F for ; Wed, 3 Nov 2021 05:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231216AbhKCFIt (ORCPT ); Wed, 3 Nov 2021 01:08:49 -0400 Received: from mail-bn7nam10on2050.outbound.protection.outlook.com ([40.107.92.50]:35137 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229650AbhKCFIn (ORCPT ); Wed, 3 Nov 2021 01:08:43 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ilzt9jXX6WFfYgGHj7qHK4MiEOabKl4ZEtIb6vCiAtoSLJpcLOepB3P0WpHBU2ojGHVf7OHCuwXqaPm9E5WQNV0Nbo8lOMJO/EdZL9LyxXFxLHxTUwjh7bBbRm7wpJSCGV87BwosevWNxYQ9Q3L9KEbywuehzWNmMKcQ2TBZVzCD2jzieX2/UVkeySYoZALhD0Qmt3bxQGYVG5QAplJoH3JSKRokO81AZq9R1v3PjCRp0wbgUwwdTnz/p5m9onoM1hr0szTtR9rfcVtS2Rbk2ryMNXXJ5hXOkkBiCBDReugHIYKMcAmJZYj6SSg11/oZI09AHf1eM7DYoeQOjp3E0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CFiwC8SkpFk9PgpgmGvI9+Or4jCrnS/cJhXLUAHQtoc=; b=IwE9KiyMRsoQAOmL43g90Lnl+32bcefPW2oBgR49r9Zvb/grF8JdyyGIJTWTk2K+NQectN69IrQt/W3kSKMviMOwCw646RRm24SpLEJxDo2NW+egQKu6MMGe/i2zpAsGKSuj4xShjRMQ/KHRE0xSYvSYeyH/ayn4NlAlBjjtdiM7v7GZlXQMbx1UhpMv2D8qqidSypMQNTDcZJyht8cZjNiGt929wQ6Aspv8D8NZoVJz74A6vQU6MMqC/WpIlizMqvdrubvbJcIlynvdtiK3DoXoZyod80bggtxkmbh/1UTZ8n4wja2KP6Am3myq927jItkkB4MFY+WShpEMbwD5kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.35) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CFiwC8SkpFk9PgpgmGvI9+Or4jCrnS/cJhXLUAHQtoc=; b=q8Uacuy46rRpuj9Bz/WOUFBdIG2b255bSInad5dKDMNk/Jqem6gD+nKH8j5Dd8LZjp0Pj1AXMsN4qOAWCBhBliYnUZwV2D63XmX0CgxqjNbX11iaOWmG1Lz41c1RmBuCqzRKMHBpihbH4SJPrmEgfEHtcE4ldK9n4uRBWUDKvvmzpjDeM8sRov3/q+NCFNZadz6xHIleQOWvI3LISNLsTTuzuPvBXJ89N7T7+XmZ6S68RWvW3n+JKdCiRxhmDUNNnmdJ59DK7Ug/recHwaOG6uWBailxzyLpfK+3txTcrQk2VAtaX5l6kEIwKSySc5l/JFYz4GasykzLV5cJcf7+ug== Received: from DS7PR06CA0050.namprd06.prod.outlook.com (2603:10b6:8:54::32) by BY5PR12MB4244.namprd12.prod.outlook.com (2603:10b6:a03:204::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Wed, 3 Nov 2021 05:06:05 +0000 Received: from DM6NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:8:54:cafe::bd) by DS7PR06CA0050.outlook.office365.com (2603:10b6:8:54::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 05:06:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35) smtp.mailfrom=nvidia.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.35 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.35; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.35) by DM6NAM11FT055.mail.protection.outlook.com (10.13.173.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 05:06:05 +0000 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 3 Nov 2021 05:05:54 +0000 Received: from audio.nvidia.com (172.20.187.5) by mail.nvidia.com (172.20.187.12) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 3 Nov 2021 05:05:52 +0000 From: Sameer Pujar To: , , , CC: , , , , , Sameer Pujar Subject: [PATCH 1/4] ASoC: tegra: Fix kcontrol put callback in ADMAIF Date: Wed, 3 Nov 2021 10:34:54 +0530 Message-ID: <1635915897-32313-2-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1635915897-32313-1-git-send-email-spujar@nvidia.com> References: <1635915897-32313-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d86dd3a1-f340-410c-f99b-08d99e87a399 X-MS-TrafficTypeDiagnostic: BY5PR12MB4244: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wR6BrYAhRJ7CL5r7qFTZ1yW4E+cn8jcIA1YJmNst/AaRN20Z0oTLUG27WszmOLDBjO4xZB3HXdpV1qTsJLhEzuNyBSSYJaYENOZEKhGWQvmKSJlROCJBu2GcEtIZXz52XUfU0aqdHsCWyzsRmqQtp1JwXhjAMpG8qzeOItWgIypgLB28d/U8OY0JFDW+LmTBAjXkFAl33Q5Vrq2j0jm6q91MjBnA12/PT+CIKgNYuM8CqaPhDDPCyF6UPL/MS0JOl2lu5LjN2+8Zwej8WYhTpNblVDHEBsksgPXJBVF0gvdJ7zZIvwsuBPUNIZf18eV5QVJbgZAB451LMFl4yfGf2QLim85WkHul5UEMqybmQqj298YIHj86nyn5tAcTgSKnllL3v33FCoUcrV4zRJnpMWUUTXO13XTrqnaJZewMGynxsI2stHNmac9afXZSxSJRxeZ0gL8pOAvxqTYQkx1y5lPXhr+6whaqgSRPtK3fphX0eCa8JegbbHIUhskZcWAjJb3F4Fd0K3vSUW6BJ18k/5Kjov7jOva5rRTXRaN/uMTUc/zrHyKB//v3wnhcrSP/0pX236AQdXRYnjlmS6j4MMSk9n6v2aqtGejKmVO1ONwHAuYAoXUhUTfsOc1/jICFb77cnHTPKlTW8h80dQ55O+BJf1rJZQb/EuCtkJn9bTWqW6Ng/ZIv6zgw0EPCjhAJpekiGI8mzCNE6VQXC812BQ== X-Forefront-Antispam-Report: CIP:216.228.112.35;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid04.nvidia.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(83380400001)(7636003)(70206006)(7696005)(86362001)(508600001)(4326008)(5660300002)(8676002)(356005)(70586007)(82310400003)(47076005)(2906002)(426003)(36860700001)(36756003)(36906005)(26005)(186003)(2616005)(8936002)(316002)(110136005)(54906003)(336012)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 05:06:05.0847 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d86dd3a1-f340-410c-f99b-08d99e87a399 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.35];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4244 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kcontrol put callback is expected to return 1 when there is change in HW or when the update is acknowledged by driver. This would ensure that change notifications are sent to subscribed applications. Update the ADMAIF driver accordingly Fixes: f74028e159bb ("ASoC: tegra: Add Tegra210 based ADMAIF driver") Suggested-by: Jaroslav Kysela Suggested-by: Mark Brown Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_admaif.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra210_admaif.c b/sound/soc/tegra/tegra210_admaif.c index bcccdf3..36ba980 100644 --- a/sound/soc/tegra/tegra210_admaif.c +++ b/sound/soc/tegra/tegra210_admaif.c @@ -460,8 +460,10 @@ static int tegra_admaif_put_control(struct snd_kcontrol *kcontrol, admaif->stereo_to_mono[ADMAIF_TX_PATH][ec->reg] = value; else if (strstr(kcontrol->id.name, "Capture Stereo To Mono")) admaif->stereo_to_mono[ADMAIF_RX_PATH][ec->reg] = value; + else + return 0; - return 0; + return 1; } static int tegra_admaif_dai_probe(struct snd_soc_dai *dai) -- 2.7.4