From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BE2C433FE for ; Thu, 4 Nov 2021 11:45:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94C9C6120D for ; Thu, 4 Nov 2021 11:45:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231559AbhKDLsf (ORCPT ); Thu, 4 Nov 2021 07:48:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229843AbhKDLs3 (ORCPT ); Thu, 4 Nov 2021 07:48:29 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CF74C061714 for ; Thu, 4 Nov 2021 04:45:52 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id k1so5844187ilo.7 for ; Thu, 04 Nov 2021 04:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=S1qFS1jMjwj/T0yJQwZvrrHWJoJ7Nzy4g0iaJHKu/8U=; b=Kd3s6O7ChYxD9JC6o9s9ReXrYG1jiSKr+18sYKuUvK89lUyVpf0eG7b+uSXK34Gjf7 h1WOCyJp3hLuBR6JE4DrkqZ+l+SJdVtnPtx7iTdRTdzeQAHoU+ZV0RuzzA/0MhcP5Lqb oihE40aHorH9SIPFZQThFxbYXzQbwzfBCD9gnA4z9aXbbIMQNf/A3rG83aPprvRbGGGY KCsWxxH6Jlb2I0cGChxp2trAmEFOmfDJSMH/1RGdUSh4WeQJBAZy1nVnhcmGLHUoTdnk qFASVJhNjRtKqYiVmmTyVo5llX2i0tNIwn2jkZNMHA5nny/1Kb4ohSFFph+Qy1R7uvuu kDtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=S1qFS1jMjwj/T0yJQwZvrrHWJoJ7Nzy4g0iaJHKu/8U=; b=kxpQlS0k0qNXobVVPrHjgnx/FsF4aOAENvq+XCh7c/mA9NcF7pJvnNNGuamm4XJ8h7 5hk3PLalC0EJcAywl4mdi2sN/xIQNg/wV//ShGj0TM7Z+Gc0pWUtxCiyD72Ax3nrttkr yTPFzrp+6r00gxls1LvhCvPtvwQSHehgphpDtkRPuRJhKicdiPtW0SuzxAT7XaNNS2RN ifZBJVlT04dSJqIk20yqF001vWgb/Pj+k4Nas48VUGHSMMy/fovgotVQNntAB67OSrmT H0ufbEtH9wZ3Hhun8hSgud3PNY6Si6faZfTrnFE2ZlNbJ1ePzCjk38+GRWJBwHA5x5m0 HKKQ== X-Gm-Message-State: AOAM5339Pcj2qbd1VjcDCEVovNGNlEqHmkv16KdMlr0NA/7bIJe8RqBr GP8NSuIAeZ+R3XedCSMSyJGGpw== X-Google-Smtp-Source: ABdhPJyl8OV+Jv4v6fXzPNd9zMbs4veLJQA2Z1RiJSGD2iP94vwTsc+5cbT4GjalzBM1M8ol8RVTOQ== X-Received: by 2002:a05:6e02:1646:: with SMTP id v6mr36447239ilu.282.1636026351484; Thu, 04 Nov 2021 04:45:51 -0700 (PDT) Received: from [127.0.1.1] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id c4sm2395231ioo.48.2021.11.04.04.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Nov 2021 04:45:51 -0700 (PDT) From: Jens Axboe To: lars.ellenberg@linbit.com, Wu Bo Cc: linux-kernel@vger.kernel.org, mcgrof@kernel.org, linfeilong@huawei.com, linux-block@vger.kernel.org In-Reply-To: <1636013229-26309-1-git-send-email-wubo40@huawei.com> References: <1636013229-26309-1-git-send-email-wubo40@huawei.com> Subject: Re: [PATCH] drbd: Fix double free problem in drbd_create_device Message-Id: <163602635079.21562.17386310945369487784.b4-ty@kernel.dk> Date: Thu, 04 Nov 2021 05:45:50 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Nov 2021 16:07:09 +0800, Wu Bo wrote: > In drbd_create_device(), the 'out_no_io_page' lable has called > blk_cleanup_disk() when return failed. > > So remove the 'out_cleanup_disk' lable to avoid double free the > disk pointer. > > > [...] Applied, thanks! [1/1] drbd: Fix double free problem in drbd_create_device commit: 27548088ac628109f70eb0b1eb521d035844dba8 Best regards, -- Jens Axboe