Re: reiser4 breaks vmware

[Nikita Danilov <Nikita@Namesys.COM>]

Nuno Silva writes:
 > Hi.
 > 
 > Shawn wrote:
 > > Forgive my line-wraps, but the following (among other do_mmap_pgoff
 > > related snippets) break vmware.
 > > 
 > > Couple questions out of this:
 > > 1. Does anyone care enough to produce a patch for vmware's module?
 > > 2. What does this change accomplish for reiser4?
 > > 
 > > diff -ruN linux-2.6.0-test9/arch/i386/kernel/sys_i386.c
 > > linux-2.6.0-test9-reiser4/arch/i386/kernel/sys_i386.c 
 > > --- linux-2.6.0-test9/arch/i386/kernel/sys_i386.c       Sat Oct 25
 > > 22:44:51 2003 
 > > +++ linux-2.6.0-test9-reiser4/arch/i386/kernel/sys_i386.c       Thu Nov
 > > 13 15:39:47 2003 
 > > @@ -56,7 +56,7 @@ 
 > >         } 
 > > 
 > >         down_write(&current->mm->mmap_sem); 
 > > -       error = do_mmap_pgoff(file, addr, len, prot, flags, pgoff); 
 > > +       error = do_mmap_pgoff(current->mm, file, addr, len, prot, flags,
 > > pgoff); 
 > >         up_write(&current->mm->mmap_sem); 
 > > 
 > >         if (file)
 > 
 > I'd say that namesys is using UML (user-mode-linux.sf.net) to develop 
 > raiser4 (smart guys, uml rocks).
 > 
 > These are probably left overs from UML's SKAS-host patch. If I'm correct 
 > you may try to reverse the SKAS patch from that tree (the patch is 
 > located at UML's site). It won't do any harm, anyway...

Exactly. I included it into core.diff by mistake.
Revert it: http://www.namesys.com/snapshots/2003.12.23/broken-out/do_mmap2-fix.diff.patch

 > 
 > Regards,
 > Nuno Silva
 > 

Nikita.