From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Claudiu <claudiu.beznea@tuxon.dev>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <p.zabel@pengutronix.de>,
<yoshihiro.shimoda.uh@renesas.com>,
<wsa+renesas@sang-engineering.com>
Cc: <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <geert+renesas@glider.be>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH net-next v3 18/19] net: ravb: Do not apply RX CSUM settings to hardware if the interface is down
Date: Mon, 8 Jan 2024 23:49:29 +0300 [thread overview]
Message-ID: <16361de1-5f90-01e6-7a4a-8faacc0fa056@omp.ru> (raw)
In-Reply-To: <20240105082339.1468817-19-claudiu.beznea.uj@bp.renesas.com>
On 1/5/24 11:23 AM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Do not apply the RX CSUM settings to hardware if the interface is down. In
s/CSUM/checksum/?
> case runtime PM is enabled, and while the interface is down, the IP will be
> in reset mode (as for some platforms disabling the clocks will switch the
> IP to reset mode, which will lead to losing registers content) and applying
> settings in reset mode is not an option. Instead, cache the RX CSUM
Same here...
> settings and apply them in ravb_open() though ravb_emac_init().
Through?
> Commit prepares for the addition of runtime PM.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
[...]
MBR, Sergey
next prev parent reply other threads:[~2024-01-08 20:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 8:23 [PATCH net-next v3 00/19] net: ravb: Add suspend to RAM and runtime PM support for RZ/G3S Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 01/19] net: ravb: Let IP-specific receive function to interrogate descriptors Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 02/19] net: ravb: Rely on PM domain to enable gptp_clk Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 03/19] net: ravb: Make reset controller support mandatory Claudiu
2024-01-05 9:38 ` Geert Uytterhoeven
2024-01-08 7:05 ` claudiu beznea
2024-01-05 8:23 ` [PATCH net-next v3 04/19] net: ravb: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and pm_ptr() Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 05/19] net: ravb: Use tabs instead of spaces Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 06/19] net: ravb: Assert/de-assert reset on suspend/resume Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 07/19] net: ravb: Move reference clock enable/disable on runtime PM APIs Claudiu
2024-01-05 19:52 ` Sergey Shtylyov
2024-01-08 8:03 ` claudiu beznea
2024-01-23 20:06 ` Sergey Shtylyov
2024-01-05 8:23 ` [PATCH net-next v3 08/19] net: ravb: Move the IRQs get and request in the probe function Claudiu
2024-01-05 20:57 ` Sergey Shtylyov
2024-01-08 8:23 ` claudiu beznea
2024-01-07 18:24 ` Sergey Shtylyov
2024-01-08 8:58 ` claudiu beznea
2024-01-09 20:47 ` Sergey Shtylyov
2024-01-10 11:55 ` claudiu beznea
2024-01-14 18:07 ` Sergey Shtylyov
2024-01-15 7:10 ` claudiu beznea
2024-01-05 8:23 ` [PATCH net-next v3 09/19] net: ravb: Split GTI computation and set operations Claudiu
2024-01-06 19:58 ` Sergey Shtylyov
2024-01-05 8:23 ` [PATCH net-next v3 10/19] net: ravb: Move delay mode set in the driver's ndo_open API Claudiu
2024-01-06 20:26 ` Sergey Shtylyov
2024-01-05 8:23 ` [PATCH net-next v3 11/19] net: ravb: Move DBAT configuration to " Claudiu
2024-01-06 20:34 ` Sergey Shtylyov
2024-01-05 8:23 ` [PATCH net-next v3 12/19] net: ravb: Move PTP initialization in the driver's ndo_open API for ccc_gac platorms Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 13/19] net: ravb: Set config mode in ndo_open and reset mode in ndo_close Claudiu
2024-01-08 19:28 ` Sergey Shtylyov
2024-01-09 5:42 ` claudiu beznea
2024-01-05 8:23 ` [PATCH net-next v3 14/19] net: ravb: Simplify ravb_suspend() Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 15/19] net: ravb: Simplify ravb_resume() Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 16/19] net: ravb: Keep the reverse order of operations in ravb_close() Claudiu
2024-01-05 8:23 ` [PATCH net-next v3 17/19] net: ravb: Return cached statistics if the interface is down Claudiu
2024-01-08 20:22 ` Sergey Shtylyov
2024-01-10 13:17 ` claudiu beznea
2024-01-14 12:22 ` Sergey Shtylyov
2024-01-15 6:08 ` claudiu beznea
2024-01-05 8:23 ` [PATCH net-next v3 18/19] net: ravb: Do not apply RX CSUM settings to hardware " Claudiu
2024-01-08 20:34 ` Sergey Shtylyov
2024-01-08 20:36 ` Sergey Shtylyov
2024-01-08 20:49 ` Sergey Shtylyov [this message]
2024-01-05 8:23 ` [PATCH net-next v3 19/19] net: ravb: Add runtime PM support Claudiu
2024-01-09 19:53 ` Sergey Shtylyov
2024-01-10 13:23 ` claudiu beznea
2024-01-05 9:58 ` [PATCH net-next v3 00/19] net: ravb: Add suspend to RAM and runtime PM support for RZ/G3S Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16361de1-5f90-01e6-7a4a-8faacc0fa056@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®